Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented exception handling for changing timeout visibility / hear… #1

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

hayes-crowley
Copy link

Monday task:
https://patternarch.monday.com/boards/2433534228/pulses/2483876310

Summary

Forked sqs-consumer and implemented a PR that has been open for some time (bbc#280)

Essentially, the issue is that sometimes the heartbeatInterval will fire its changeVisibilityTimeout request after a message has been deleted (the receiptHandleID is invalid). This returns an error from SQS:

"Receipt Handle is invalid. Reason: Message does not exist or is not available for visibility timeout change."

that was not being handled due to not returning an await statement within an async function (see diff). We should no longer be getting unhandled exceptions in the logs.

Testing plan

  1. Set heartbeat interval and visbilityTimeout to a very low value in ct_node (e.g., 1 and 5 respectively)
  2. Run daylight analysis
  3. Confirm that change visibility error is being logged instead of "unhandled exceptions"

@hayes-crowley hayes-crowley merged commit f35471e into master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants