Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #275 - Fix visibility timeout error handler #280

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

rafael-pb
Copy link
Contributor

Description

  • Added await to changeMessageVisibility and changeMessageVisibilityBatchBatch calls to SQS
  • Convert error using toSQSError when catching visibility timeout errors
  • Added unit tests

Motivation and Context

Fixes issue #275: visibility timeout changes are mostly used by the heartbeat (inside a Timer) that does not catch errors nor wait for the promise to be resolved. In those cases, it caused an unhandled exception/rejection.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rafael-pb rafael-pb requested a review from a team as a code owner October 13, 2021 20:03
@RobPethick
Copy link
Contributor

We are also experiencing this error

@RobPethick
Copy link
Contributor

@memsb thank you for merging this one - it is so important to us. Could you release an updated npm version for this?

@memsb
Copy link

memsb commented Apr 21, 2022

Version 5.7 was released today and includes this PR

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants