Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): deploy patch&minor at the right place #3737

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Mar 21, 2024

We had an incident where, for version v.X.Y.Z, we deployed /vX/, /vY/ and /vZ/ to our CDN instead of /vX/, /vX.Y/ and /vX.Y.Z/.
faeba9f fixes that, and b0a208d ensure deployment to a given environment can start only after manual approval.
We want the latter to verify our fix is working.

https://coveord.atlassian.net/browse/CDX-1535

@louis-bompart louis-bompart requested a review from a team as a code owner March 21, 2024 19:23
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 197.8 197.8 0
commerce 242.2 242.2 0
search 355.6 355.6 0
insight 334.4 334.4 0
product-listing 252 252 0
product-recommendation 170.5 170.5 0
recommendation 212.7 212.7 0
ssr 349.7 349.7 0

@louis-bompart
Copy link
Collaborator Author

louis-bompart commented Mar 22, 2024

@louis-bompart louis-bompart added this pull request to the merge queue Mar 22, 2024
Merged via the queue into master with commit c777c7c Mar 22, 2024
85 checks passed
@louis-bompart louis-bompart deleted the chore/deploy-to-correct-v branch March 22, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants