Skip to content

Commit

Permalink
chore(ci): deploy patch&minor at the right place (#3737)
Browse files Browse the repository at this point in the history
We had an incident where, for version v.X.Y.Z, we deployed `/vX/`,
`/vY/` and `/vZ/` to our CDN instead of `/vX/`, `/vX.Y/` and `/vX.Y.Z/`.
faeba9f fixes that, and
b0a208d ensure deployment to a given
environment can start only after manual approval.
We want the latter to verify our fix is working.

https://coveord.atlassian.net/browse/CDX-1535
  • Loading branch information
louis-bompart authored Mar 22, 2024
1 parent 8f4d68d commit c777c7c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .deployment.config.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"sequential": ["dev", "stg", "prd"]
},
"team_jenkins": "searchuibuilds",
"start_environment_automatically": true,
"start_environment_automatically": false,
"notifications": {
"slack_channels": ["#searchuibuilds"]
}
Expand Down
16 changes: 8 additions & 8 deletions scripts/deploy/execute-deployment-pipeline.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,16 @@ const atomicHostedPage = getVersionComposants(atomicHostedPageJson.version);
console.log(execSync(`
deployment-package package create --with-deploy \
--resolve HEADLESS_MAJOR_VERSION=${headless.major} \
--resolve HEADLESS_MINOR_VERSION=${headless.minor} \
--resolve HEADLESS_PATCH_VERSION=${headless.patch} \
--resolve HEADLESS_MINOR_VERSION=${headless.major}.${headless.minor} \
--resolve HEADLESS_PATCH_VERSION=${headless.major}.${headless.minor}.${headless.patch} \
--resolve ATOMIC_MAJOR_VERSION=${atomic.major} \
--resolve ATOMIC_MINOR_VERSION=${atomic.minor} \
--resolve ATOMIC_PATCH_VERSION=${atomic.patch} \
--resolve ATOMIC_MINOR_VERSION=${atomic.major}.${atomic.minor} \
--resolve ATOMIC_PATCH_VERSION=${atomic.major}.${atomic.minor}.${atomic.patch} \
--resolve ATOMIC_REACT_MAJOR_VERSION=${atomicReact.major} \
--resolve ATOMIC_REACT_MINOR_VERSION=${atomicReact.minor} \
--resolve ATOMIC_REACT_PATCH_VERSION=${atomicReact.patch} \
--resolve ATOMIC_REACT_MINOR_VERSION=${atomicReact.major}.${atomicReact.minor} \
--resolve ATOMIC_REACT_PATCH_VERSION=${atomicReact.major}.${atomicReact.minor}.${atomicReact.patch} \
--resolve ATOMIC_HOSTED_PAGE_MAJOR_VERSION=${atomicHostedPage.major} \
--resolve ATOMIC_HOSTED_PAGE_MINOR_VERSION=${atomicHostedPage.minor} \
--resolve ATOMIC_HOSTED_PAGE_PATCH_VERSION=${atomicHostedPage.patch} \
--resolve ATOMIC_HOSTED_PAGE_MINOR_VERSION=${atomicHostedPage.major}.${atomicHostedPage.minor} \
--resolve ATOMIC_HOSTED_PAGE_PATCH_VERSION=${atomicHostedPage.major}.${atomicHostedPage.minor}.${atomicHostedPage.patch} \
--resolve GITHUB_RUN_ID=${process.env.RUN_ID} \
--changeset ${releaseCommit}`.replaceAll(/\s+/g, ' ').trim()).toString());

0 comments on commit c777c7c

Please sign in to comment.