Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-3324: Add startup cnf logging to DefaultDbConfig (#6381) #6459

Merged
merged 1 commit into from
Sep 25, 2023
Merged

CBG-3324: Add startup cnf logging to DefaultDbConfig (#6381) #6459

merged 1 commit into from
Sep 25, 2023

Conversation

mohammed-madi
Copy link
Contributor

(cherry picked from commit 5288dbf)

CBG-3440

  • Copy startup config logging to default db config, to be returned on GET /db/_config?include_runtime=true calls
  • Add check on TestConfigsIncludeDefaults

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Dependencies (if applicable)

  • Link upstream PRs
  • Update Go module dependencies when merged

Integration Tests

@mohammed-madi mohammed-madi merged commit 2b55459 into release/3.1.2 Sep 25, 2023
20 checks passed
@mohammed-madi mohammed-madi deleted the CBG-3440 branch September 25, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrks bbrks bbrks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohammed-madi @bbrks