Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-3324: Add startup cnf logging to DefaultDbConfig #6381

Merged
merged 4 commits into from
Aug 24, 2023
Merged

CBG-3324: Add startup cnf logging to DefaultDbConfig #6381

merged 4 commits into from
Aug 24, 2023

Conversation

mohammed-madi
Copy link
Contributor

CBG-3324

Describe your PR here...

  • Copy startup config logging to default db config, to be returned on GET /db/_config?include_runtime=true calls
  • Add check on TestConfigsIncludeDefaults

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Dependencies (if applicable)

  • Link upstream PRs
  • Update Go module dependencies when merged

Integration Tests

bbrks
bbrks requested changes Aug 24, 2023
View reviewed changes
rest/config_database.go Show resolved Hide resolved
bbrks
bbrks requested changes Aug 24, 2023
View reviewed changes
Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nitpick on copy/pasted test comment :)

rest/adminapitest/admin_api_test.go Outdated Show resolved Hide resolved
@bbrks bbrks merged commit 5288dbf into master Aug 24, 2023
26 checks passed
@bbrks bbrks deleted the CBG-3324 branch August 24, 2023 16:31
mohammed-madi added a commit that referenced this pull request Sep 25, 2023
@mohammed-madi
CBG-3324: Add startup cnf logging to DefaultDbConfig (#6381)
9ca60b8 
(cherry picked from commit 5288dbf)
mohammed-madi added a commit that referenced this pull request Sep 25, 2023
@mohammed-madi
CBG-3324: Add startup cnf logging to DefaultDbConfig (#6381)
4384c37 
(cherry picked from commit 5288dbf)
mohammed-madi added a commit that referenced this pull request Sep 25, 2023
@mohammed-madi
CBG-3324: Add startup cnf logging to DefaultDbConfig (#6381) (#6459)
2b55459 
(cherry picked from commit 5288dbf)
bbrks pushed a commit that referenced this pull request Mar 28, 2024
@mohammed-madi @bbrks
CBG-3324: Add startup cnf logging to DefaultDbConfig (#6381)
00fda14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrks bbrks bbrks approved these changes

Assignees

@bbrks bbrks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohammed-madi @bbrks