Fix faulty iterator callsite callback return booleans #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpoke
approved these changes
Nov 8, 2022
| @@ -140,7 +140,7 @@ func (k Keeper) ExportGenesis(ctx sdk.Context) (genesis *consumertypes.GenesisSt | |||
| ValidatorConsensusAddress: addr, | |||
| } | |||
| outstandingDowntimes = append(outstandingDowntimes, od) | |||
| return false | |||
There was a problem hiding this comment.
Add comments describing the intended outcome, e.g., continue iterating. It will make it easier to change afterwards to the SDK pattern.
| @@ -43,7 +43,7 @@ func (k Keeper) QueryConsumerChains(goCtx context.Context, req *types.QueryConsu | |||
| ChainId: chainID, | |||
| ClientId: clientID, | |||
| }) | |||
| return false | |||
| return true | |||
There was a problem hiding this comment.
Until a better fix, change the return field from stop to continue, i.e.,
func (k Keeper) IterateConsumerChains(ctx sdk.Context, cb func(ctx sdk.Context, chainID, clientID string) (continue bool)) {
| @@ -354,7 +354,7 @@ func (k Keeper) EndBlockCCR(ctx sdk.Context) { | |||
| return false | |||
| }) | |||
| // continue to iterate through all consumers | |||
| return true | |||
| return false | |||
There was a problem hiding this comment.
ditto: IterateChannelToChain change stop to continue
|
I merged to get the fix in as changing the New issue |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some errors in the way we were using iterators.
This PR fixes 5 bugs. I could have easily made a mistake and missed others, as it's a bit error prone.
( Fixes #433 )
Note: based on concerns to minimize diffs I flipped the bools to fix the issues. Really we need a larger change to match the SDK pattern. Please see here #440 for discussion of a larger solution where we'd change our iterators to match the SDK style.
This could have been avoided with better guidelines about var naming IMO.