We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interchain-security/x/ccv/provider/keeper/relay.go
Lines 356 to 357 in c8a762c
I think it should return false, rather than true.
interchain-security/x/ccv/provider/keeper/keeper.go
Lines 200 to 202 in c8a762c
Fix the iteration if necessary, and add a regression test
The text was updated successfully, but these errors were encountered:
Nice catch @danwt. IMO the fix entails changing the if condition to
if !cb(ctx, channelID, chainID)
in order to be consistent with the other iterators.
Sorry, something went wrong.
Could be worthwhile to also create a UT for EndBlockCCR to catch these types of errors. The e2e tests have only one consumer chain.
EndBlockCCR
doContinue
Successfully merging a pull request may close this issue.
Problem
interchain-security/x/ccv/provider/keeper/relay.go
Lines 356 to 357 in c8a762c
I think it should return false, rather than true.
interchain-security/x/ccv/provider/keeper/keeper.go
Lines 200 to 202 in c8a762c
Closing criteria
Fix the iteration if necessary, and add a regression test
TODOs
The text was updated successfully, but these errors were encountered: