Constant Length Key Prefixes #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaspitz
requested review from
AdityaSripal,
jtremback,
mpoke,
sainoe and
danwt
as code owners
sainoe
reviewed
Jul 25, 2022
sainoe
reviewed
Jul 25, 2022
|
Good work @smarshall-spitzbart ! Just a few details. I agree that we should decide if we use separators in keys. Any thoughts on this @danwt @jtremback ? |
|
I think we should avoid separators if we can as they can just lead to bugs. |
|
All key separators have been removed as of latest commit |
mpoke
approved these changes
Jul 29, 2022
jtremback
reviewed
Aug 1, 2022
jtremback
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18
Prefixes and singular keys are now defined as byte constants, assigned with iota. Corresponding helpers returning
[]byteare defined in the same file as the byte constants.Comments:
This PR enforces the semantics of a "key"/"singular key" and a "key prefix" in some places. The former being a key associated to a single value (or a single sequence of values marshaled/unmarshaled together), while the latter is a prefix where further bytes are appended to the key to retrieve values.
It may be worth standardizing on where/if we use separators at all. Update after discussions - Separators (
"/") were removed wherever possible from existing key functions.