Check oder of iteration #599
Conversation
mpoke
requested review from
jtremback,
sainoe,
danwt and
shaspitz
as code owners
| ctx := sdk.UnwrapSDKContext(goCtx) | ||
| props := k.GetAllConsumerAdditionProps(ctx) | ||
| props := types.ConsumerAdditionProposals{} | ||
| k.IteratePendingConsumerAdditionProps(ctx, func(prop types.ConsumerAdditionProposal) (stop bool) { |
There was a problem hiding this comment.
What is the reasoning behind using the iterate method instead of GetAllConsumerAdditionProps?
There was a problem hiding this comment.
GetAllConsumerAdditionProps was only used here. Just wanted to cleanup the code. We could revert back if you think it's useful to have it. @MSalopek was also saying he prefers to have it.
There was a problem hiding this comment.
I have some nitpicks, but those are not that important.
Would you mind clarifying how #596 will be integrated with regards to this PR? There is a fair amount of overlap between this PR and #596, some sort of agreement and scheduling as to when and where both of these commits get merged seems to be required.
@jtremback can say more on that as he's currently working on #596 |
use sdk func instead of binary.BigEndian.
|
Close in favor of #620 |
Description
Based on #583:
Linked issues
Closes: #537
Type of change
If you've checked more than one of the first three boxes, consider splitting this PR into multiple PRs!
Fix: Changes and/or adds code behavior, specifically to fix a bugRefactor: Changes existing code style, naming, structure, etc.Docs: Adds documentationRegression tests
If
Refactor, describe the new or existing tests that verify no behavior was changed or added where refactors were introduced.New behavior tests
Several tests were updated.