Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility test change (backport #2063) #2065

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 19, 2024

Description

Compatibility test runs the provider for version v4.4.0 but in v4.4.0 this PR's removed testcase is not failing:

2024/07/18 18:17:58 expected error not raised: expected: 'a validator has assigned the consumer key already: consumer key is already in use by a validator', got 'gas estimate: 32519
{"height":"0","txhash":"110BA23D8388914624EC58F8842683B7DC238635CE93FD69F20A28E27541B9D2","codespace":"","code":0,"data":"","raw_log":"[]","logs":[],"info":"","gas_wanted":"0","gas_used":"0","tx":null,"timestamp":"","events":[]}
'

The testcase starts failing after the change performed here.

This PR removes this testcase so that the compatibility test does not complain. Note however, that the removed testcase still resides here (e.g., in the happy-path) and hence we do not miss anything by removing this testcase from the compatibility test.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

Summary by CodeRabbit

  • Bug Fixes
    • Removed a test case that checked for operation failure when a consumer public key is assigned by the same validator, refining the testing logic.
    • Updated the remaining test case to focus on failure conditions related to consumer public keys assigned by different validators.

This is an automatic backport of pull request #2063 done by [Mergify](https://mergify.com).

init commit

(cherry picked from commit 9bdc104)
@mergify mergify bot requested a review from a team as a code owner July 19, 2024 07:29
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Jul 19, 2024
@insumity insumity merged commit b73dab8 into release/v5.1.x Jul 19, 2024
14 checks passed
@insumity insumity deleted the mergify/bp/release/v5.1.x/pr-2063 branch July 19, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants