Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waitBlocks for *both* chains on relayPackets #1236

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

p-offtermatt
Copy link
Contributor

@p-offtermatt p-offtermatt commented Aug 25, 2023

Description

Closes: #1235

Adds waitBlocks on both chains in relayPackets - either chain might be source or destination, and it seems inconsistent to wait only for one of the chains.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@p-offtermatt p-offtermatt requested a review from a team as a code owner August 25, 2023 08:34
@p-offtermatt p-offtermatt marked this pull request as draft August 25, 2023 08:34
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Aug 25, 2023
@p-offtermatt p-offtermatt marked this pull request as ready for review August 25, 2023 09:49
@p-offtermatt p-offtermatt merged commit b18a317 into main Aug 25, 2023
@p-offtermatt p-offtermatt deleted the ph/fix-cometmock-state-checks branch August 25, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CometMock tests fail state assertions
3 participants