Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CometMock tests fail state assertions #1235

Closed
p-offtermatt opened this issue Aug 25, 2023 · 0 comments · Fixed by #1236
Closed

CometMock tests fail state assertions #1235

p-offtermatt opened this issue Aug 25, 2023 · 0 comments · Fixed by #1236
Assignees
@p-offtermatt
Labels
scope: testing Code review, testing, making sure the code is following the specification. type: bug Issues that need priority attention -- something isn't working

Comments

@p-offtermatt
Copy link
Contributor

CometMock tests fail the state assertions sometimes, see
https://github.com/cosmos/interchain-security/actions/runs/5966066269/job/16184919826

This seems distinct from #1205
@p-offtermatt p-offtermatt added type: bug Issues that need priority attention -- something isn't working scope: testing Code review, testing, making sure the code is following the specification. labels Aug 25, 2023
@p-offtermatt p-offtermatt self-assigned this Aug 25, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Aug 25, 2023
@p-offtermatt p-offtermatt moved this from 🩹 Triage to 🏗 In progress in Cosmos Hub Aug 25, 2023
@p-offtermatt p-offtermatt mentioned this issue Aug 25, 2023
Merged
8 tasks
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Cosmos Hub Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p-offtermatt p-offtermatt

Labels
scope: testing Code review, testing, making sure the code is following the specification. type: bug Issues that need priority attention -- something isn't working
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add waitBlocks for *both* chains on relayPackets cosmos/interchain-security
1 participant
@p-offtermatt