Unbonding ops are put on hold even w/o consumer chains

[mpoke]

Closes #117

[AdityaSripal]

what happens theoretically if the unbonding is put on hold while child chains exist, but then child chain gets removed with gov proposal before hold is lifted?

[mpoke]

That's where the lockUnbondingOnTimeout parameter is used (see technical spec). The consumer chain is removed using the function specified here, i.e.,

function StopConsumerChain(chainId: string, lockUnbonding: Bool)

However, now that I look at it, the code is not covering the removal of a consumer chain when there is only one consumer chain, i.e.,

  if !lockUnbonding {
    // remove chainId form all outstanding unbonding operations
    foreach id IN vscToUnbondingOps[(chainId, _)] {
      unbondingOps[id].unbondingChainIds.Remove(chainId)
      if unbondingOps[id].unbondingChainIds.IsEmpty() {
        // notify the Staking module that the unbonding can complete
        stakingKeeper.UnbondingCanComplete(id)
        // remove unbonding operation
        unbondingOps.Remove(id)
      }
    }
    // clean up vscToUnbondingOps mapping
    vscToUnbondingOps.Remove((chainId, _))
  }

Basically, the code in onRecvVSCMaturedPacket should be called (see here).

[mpoke]

Nice catch @AdityaSripal

[sainoe]

Nice catch @mpoke ! LGTM