Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the only consumer chain #122

Closed
mpoke opened this issue Jun 2, 2022 · 6 comments
Closed

Removing the only consumer chain #122

mpoke opened this issue Jun 2, 2022 · 6 comments
Assignees
Labels
type: bug Issues that need priority attention -- something isn't working

Comments

@mpoke
Copy link
Contributor

mpoke commented Jun 2, 2022

ref.

what happens theoretically if the unbonding is put on hold while child chains exist, but then child chain gets removed with gov proposal before hold is lifted?

@mpoke mpoke added type: bug Issues that need priority attention -- something isn't working ccv-core labels Jun 2, 2022
@mpoke mpoke moved this to Todo in Replicated Security Jun 2, 2022
@mpoke mpoke self-assigned this Jun 8, 2022
@mpoke mpoke added the mvcc label Jun 8, 2022
@danwt
Copy link
Contributor

danwt commented Jun 26, 2022

Can we make this issue actionable, or define a closing criteria?

@mpoke
Copy link
Contributor Author

mpoke commented Jun 27, 2022

Can we make this issue actionable, or define a closing criteria?

The implementation should follow the fix in the spec cosmos/ibc#770

@mpoke mpoke moved this from Todo to Next in Replicated Security Jun 29, 2022
@mpoke
Copy link
Contributor Author

mpoke commented Jun 29, 2022

Already fixed by

if len(unbondingOp.UnbondingConsumerChains) == 0 {
. @danwt Could you please confirm this?

@mpoke mpoke closed this as completed Jun 29, 2022
Repository owner moved this from Next to Done in Replicated Security Jun 29, 2022
@danwt
Copy link
Contributor

danwt commented Jun 29, 2022

@mpoke just from that line it seems like it. Do you have a situation or complication in mind?

@mpoke
Copy link
Contributor Author

mpoke commented Jun 29, 2022

No, this was the scenario we wanted to handle, i.e., stoping a consumer chain that was the only chain an unbonding op was waiting for.

@danwt
Copy link
Contributor

danwt commented Jun 29, 2022

It seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issues that need priority attention -- something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants