Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC: Implement and integrate CometMock #932

Closed
7 tasks done
p-offtermatt opened this issue May 9, 2023 · 0 comments
Closed
7 tasks done

EPIC: Implement and integrate CometMock #932

p-offtermatt opened this issue May 9, 2023 · 0 comments
Assignees
Labels
admin: epic An EPIC -- meta issue used to track a body of work S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.

Comments

@p-offtermatt
Copy link
Contributor

p-offtermatt commented May 9, 2023

Problem

We would like to mock out CometBFT in our end-to-end tests, since we
want to test the underlying application, but we do not care about actually running
a replicated state machine resistant to byzantine faults - just running a state machine is enough for testing.
Mocking out the consensus layer means we can skip
waiting for the network communication in the potentially multiple rounds
needed for CometBFT to come to consensus.
Thus, this can make the existing tests which are running full nodes faster.

Looking further, it can also enable writing tests with new functionality,
as CometMock can mock arbitrary timestamps coming from Comet,
and we can finely control which validators sign and don't sign which blocks.

Closing criteria

CometMock has been implemented in a proper repository.
It is integrated in our CI pipeline(s) and covers all common usecases
in a way that is delightful to use.

Problem details

Task list

Must have

  1. scope: testing
    p-offtermatt
  2. scope: testing
    p-offtermatt
  3. p-offtermatt
  4. S: Productivity
    p-offtermatt
  5. p-offtermatt

Nice to have

  1. p-offtermatt
  2. S: Productivity scope: testing
    p-offtermatt
@p-offtermatt p-offtermatt added admin: epic An EPIC -- meta issue used to track a body of work status: waiting-triage This issue/PR has not yet been triaged by the team. labels May 9, 2023
@p-offtermatt p-offtermatt changed the title EPIC: Implement and integraye CometMock EPIC: Implement and integrate CometMock May 10, 2023
@p-offtermatt p-offtermatt added scope: testing Code review, testing, making sure the code is following the specification. and removed status: waiting-triage This issue/PR has not yet been triaged by the team. labels Jun 2, 2023
@mpoke mpoke added the S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth label Sep 13, 2023
@mpoke mpoke closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin: epic An EPIC -- meta issue used to track a body of work S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants