Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CometMock-specific functionality: Advancing Blocks, Advancing Time, and Downtime #938

Closed
Tracked by #932
p-offtermatt opened this issue May 10, 2023 · 0 comments · Fixed by informalsystems/CometMock#4
Closed
Tracked by #932

Implement CometMock-specific functionality: Advancing Blocks, Advancing Time, and Downtime #938

p-offtermatt opened this issue May 10, 2023 · 0 comments · Fixed by informalsystems/CometMock#4
Assignees
@p-offtermatt
Labels
scope: testing Code review, testing, making sure the code is following the specification.

Comments

@p-offtermatt
Copy link
Contributor

p-offtermatt commented May 10, 2023 •
edited
Loading

Problem

CometMock should eventually provide specific functionality like advancing time, choosing signers and proposers,
running empty blocks, etc.
These custom endpoints should eventually be used in our e2e tests if we need more advanced testing behaviour.

Closing criteria

CometMock implements custom endpoints for advancing time, advancing blocks, and causing downtime.

Related issues

#1006 the issue for integrating this functionality in the e2e tests
@p-offtermatt p-offtermatt mentioned this issue May 10, 2023
Closed
@p-offtermatt p-offtermatt self-assigned this May 10, 2023
@p-offtermatt p-offtermatt changed the title Integrate CometMock-specific functionality in e2e tests Integrate CometMock-specific functionality in e2e tests: Advancing Blocks and Downtime Jun 12, 2023
@p-offtermatt p-offtermatt changed the title Integrate CometMock-specific functionality in e2e tests: Advancing Blocks and Downtime Integrate CometMock-specific functionality in e2e tests: Advancing Blocks, Advancing Time, and Downtime Jun 12, 2023
@p-offtermatt p-offtermatt changed the title Integrate CometMock-specific functionality in e2e tests: Advancing Blocks, Advancing Time, and Downtime Implement CometMock-specific functionality: Advancing Blocks, Advancing Time, and Downtime Jun 14, 2023
@p-offtermatt p-offtermatt mentioned this issue Jun 14, 2023
Closed
3 tasks
@p-offtermatt p-offtermatt linked a pull request Jun 14, 2023 that will close this issue
Add functionality for advancing blocks, advancing time, and causing downtime informalsystems/CometMock#4
Merged
@p-offtermatt p-offtermatt mentioned this issue Jun 16, 2023
Merged
@p-offtermatt p-offtermatt added the scope: testing Code review, testing, making sure the code is following the specification. label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p-offtermatt p-offtermatt

Labels
scope: testing Code review, testing, making sure the code is following the specification.
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
1 participant
@p-offtermatt