Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change validate_self_client error type to ContextError #483

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

Farhad-Shabani
Copy link
Member

Closes: #482


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani self-assigned this Feb 28, 2023
@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review February 28, 2023 19:23
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage: 17.85% and project coverage change: -0.05 ⚠️

Comparison is base (67c2c46) 71.52% compared to head (b350afb) 71.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
- Coverage   71.52%   71.48%   -0.05%     
==========================================
  Files         125      125              
  Lines       15886    15899      +13     
==========================================
+ Hits        11363    11365       +2     
- Misses       4523     4534      +11     
Impacted Files Coverage Δ
crates/ibc/src/core/context.rs 84.34% <ø> (ø)
crates/ibc/src/hosts/tendermint.rs 0.00% <0.00%> (ø)
crates/ibc/src/mock/context.rs 73.68% <55.55%> (-0.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@plafer plafer merged commit 7071821 into main Feb 28, 2023
@plafer plafer deleted the farhad/validate-self-client-error-type branch February 28, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

validate_self_client() should return ContextError instead of ConnectionError
2 participants