Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate_self_client() should return ContextError instead of ConnectionError #482

Closed
Tracked by #431
Farhad-Shabani opened this issue Feb 28, 2023 · 0 comments · Fixed by #483
Closed
Tracked by #431

validate_self_client() should return ContextError instead of ConnectionError #482

Farhad-Shabani opened this issue Feb 28, 2023 · 0 comments · Fixed by #483
Assignees
@Farhad-Shabani
Labels
A: breaking Admin: breaking change that may impact operators
Milestone
v0.31.0

Comments

@Farhad-Shabani
Copy link
Member

Summary

validate_self_client() should return ContextError instead of ConnectionError in order to get consistent and match the other ValidationContext methods.
@Farhad-Shabani Farhad-Shabani self-assigned this Feb 28, 2023
@Farhad-Shabani Farhad-Shabani moved this to 🏗️ In Progress in ibc-rs Feb 28, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Feb 28, 2023
Merged
7 tasks
@Farhad-Shabani Farhad-Shabani added this to the v0.31.0 milestone Feb 28, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in ibc-rs Feb 28, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Feb 28, 2023
Closed
@Farhad-Shabani Farhad-Shabani added the A: breaking Admin: breaking change that may impact operators label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Farhad-Shabani Farhad-Shabani

Labels
A: breaking Admin: breaking change that may impact operators
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.31.0
Development

Successfully merging a pull request may close this issue.

Change validate_self_client error type to ContextError cosmos/ibc-rs
1 participant
@Farhad-Shabani