Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require ICS20 module to implement Channel{Reader,Keeper} #244

Merged
merged 13 commits into from
Nov 18, 2022
Merged

Don't require ICS20 module to implement Channel{Reader,Keeper} #244

merged 13 commits into from
Nov 18, 2022

Commits on Nov 16, 2022

  1. Add SendPacketReader trait with blanket impl for all types implementi… 

    …ng ChannelReader
    @hu55a1n1
    hu55a1n1 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    e923815 View commit details
    Browse the repository at this point in the history

  2. Have SendPacket handler depend on SendPacketReader and return SendPac… 

    …ketResult
    @hu55a1n1
    hu55a1n1 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    afb8d6b View commit details
    Browse the repository at this point in the history

  3. Define Ics20ChannelKeeper and depend on that instead of Channel{Reade… 

    …r,Keeper}
    @hu55a1n1
    hu55a1n1 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    00ae707 View commit details
    Browse the repository at this point in the history

  4. Update tests

    @hu55a1n1
    hu55a1n1 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    6974ff6 View commit details
    Browse the repository at this point in the history

  5. Add blanket impl for Ics20ChannelKeeper

    @hu55a1n1
    hu55a1n1 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    42ff93f View commit details
    Browse the repository at this point in the history

  6. Add changelog entry

    @hu55a1n1
    hu55a1n1 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    0e9217f View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Use where clause for trait bounds

    @hu55a1n1
    hu55a1n1 committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    b5dc9f3 View commit details
    Browse the repository at this point in the history

  2. Avoid trait object param in send_packet handler

    @hu55a1n1
    hu55a1n1 committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    b81611a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into hu55a1n1/182-ics20-channel-reader-keeper

    @hu55a1n1
    hu55a1n1 authored Nov 17, 2022
    Configuration menu
    Copy the full SHA
    2e9a731 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Apply suggestion to merge Ics20ChannelKeeper into Ics20Keeper

    @hu55a1n1
    hu55a1n1 committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    ccff7f7 View commit details
    Browse the repository at this point in the history

  2. Rename Ics20Keeper -> TokenTransferKeeper

    @hu55a1n1
    hu55a1n1 committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    a652451 View commit details
    Browse the repository at this point in the history

  3. Rename Ics20Reader -> TokenTransferReader

    @hu55a1n1
    hu55a1n1 committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    a87e4eb View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into hu55a1n1/182-ics20-channel-reader-keeper

    @hu55a1n1
    hu55a1n1 authored Nov 18, 2022
    Configuration menu
    Copy the full SHA
    7a06e36 View commit details
    Browse the repository at this point in the history