Don't require ICS20 module to implement Channel{Reader,Keeper} #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
plafer
suggested changes
Nov 16, 2022
plafer
approved these changes
Nov 18, 2022
plafer
reviewed
Nov 18, 2022
| ChannelKeeper + BankKeeper<AccountId = <Self as Ics20Keeper>::AccountId> | ||
| { | ||
| type AccountId; | ||
| pub trait Ics20Keeper: BankKeeper { |
There was a problem hiding this comment.
In light of #247, can we rename this to TokenTransferKeeper?
| } | ||
|
|
||
| pub trait Ics20Reader: ChannelReader { | ||
| pub trait Ics20Reader: SendPacketReader { |
There was a problem hiding this comment.
And this to TokenTransferReader?
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Add SendPacketReader trait with blanket impl for all types implementing ChannelReader
* Have SendPacket handler depend on SendPacketReader and return SendPacketResult
* Define Ics20ChannelKeeper and depend on that instead of Channel{Reader,Keeper}
* Update tests
* Add blanket impl for Ics20ChannelKeeper
* Add changelog entry
* Use where clause for trait bounds
* Avoid trait object param in send_packet handler
* Apply suggestion to merge Ics20ChannelKeeper into Ics20Keeper
* Rename Ics20Keeper -> TokenTransferKeeper
* Rename Ics20Reader -> TokenTransferReader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #182 (potential solution)
With these changes, we no longer require an ICS20 module (i.e. the type implementing
Ics20Context) to implement the completeChannelReaderandChannelKeepertraits. We only require them to implement theIcs20ChannelKeeperand theSendPacketReadertraits ->ibc-rs/crates/ibc/src/applications/transfer/context.rs
Lines 25 to 26 in 42ff93f
Moreover, we also provide blanket impls for both these traits (i.e.
Ics20ChannelKeeperandSendPacketReader) if the type implementsChannelReaderandChannelKeeperrespectively.PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.