Implement (parts of) ibc-go/ADR006

[hu55a1n1]

Summary

This is a tracking issue for the Q1 objective of "Implementing of relevant parts of ADR006 (AKA 02-client-refactor)"
(See cosmos/ibc-go#1871 for more context)

Acceptance Criteria

• merging header/misbehaviour interface and renaming to ClientMessage
• Investigate moving verify_delay_passed to a more appropriate section #404
• [ICS02] Replace specific verify_functions with generic verify_membership and verify_non_membership #530
• [ICS02] Split check_misbehaviour_and_update_state and check_header_and_update_state into two sets of validation/execution functions #535
• setting client/consensus states within the light client instead of at the 02-client level
• emission of upgraded consensus state
• We should add a check that incoming header's trusted_validators matches the next_validators_hash that was persisted in the trusted consensus state (copied from Incomplete ICS 007 ClientState verification methods implementation #22 as this wasn't addressed in Incomplete ICS 007 ClientState verification methods implementation #22 and depends on 02-client-refactor changes)
  • Equivalent check in ibc-go is here: https://github.com/cosmos/ibc-go/blob/147e0f1954ede691bb977ff185b9d0500ec4bd0a/modules/light-clients/07-tendermint/types/update.go#L152
  • The check is significant b/c the header's trusted_validator_set is used in the trusted block state in verify: https://github.com/informalsystems/ibc-rs/blob/b44ade9f88c7faf4d0b6f9e672dbef08d2ab3817/modules/src/clients/ics07_tendermint/client_def.rs#L98

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate milestone (priority) applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[hu55a1n1]

We must add fix the misbehaviour execute handler to not perform full verification. (see #290 (review))

[Farhad-Shabani]

Looks like we've resolved items of this issue. @plafer, could you also check?

[plafer]

Yup!

[plafer]

Yup!