Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICS02] Split check_misbehaviour_and_update_state and check_header_and_update_state into two sets of validation/execution functions #535

Closed
5 tasks done
Tracked by #608
, #554 ,  #173
...
Farhad-Shabani opened this issue Mar 15, 2023 · 0 comments · Fixed by #584
Closed
5 tasks done
Tracked by #608
, #554 ,  #173
...

[ICS02] Split check_misbehaviour_and_update_state and check_header_and_update_state into two sets of validation/execution functions #535

Farhad-Shabani opened this issue Mar 15, 2023 · 0 comments · Fixed by #584
Assignees
@plafer
Labels
A: breaking Admin: breaking change that may impact operators O: decoupling Objective: aims to separate concerns and cause to independent, reusable components O: logic Objective: aims for better implementation logic O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Milestone
v0.37.0

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Mar 15, 2023 •
edited
Loading

Problem Statement

Part of #173, in continuation of implementing IBC-go/ADR006 and getting check_header_and_update_state() and check_misbehaviour_and_update_state() compatible with the Validation/Execution design (ADR005)

Related Issues
Beta Give feedback
  1. tendermint light client: check_{header,misbehaviour}_and_update_state() missing trusted_validator_set hash check #583
    A: bug A: critical
    plafer
  2. check_header_and_update_state: missing Header.height() vs Header.trusted_height check #585
    plafer
  3. check_misbehaviour_and_update_state(): commit verification might use the wrong chainId #589
    A: bug
    plafer
  4. Update client: missing timestamp monotonicity checks to freeze the client #598
    A: bug
    plafer
  5. check_header_and_update_state() always updates the ClientState.latest_height #601
    A: bug
@Farhad-Shabani Farhad-Shabani added A: breaking Admin: breaking change that may impact operators O: logic Objective: aims for better implementation logic O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding O: decoupling Objective: aims to separate concerns and cause to independent, reusable components labels Mar 15, 2023
@Farhad-Shabani Farhad-Shabani moved this to 📥 To Do in ibc-rs Mar 15, 2023
This was referenced Mar 15, 2023
Closed
Open
@plafer plafer mentioned this issue Mar 30, 2023
Merged
23 tasks
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Apr 13, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.37.0 milestone Apr 13, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plafer plafer

Labels
A: breaking Admin: breaking change that may impact operators O: decoupling Objective: aims to separate concerns and cause to independent, reusable components O: logic Objective: aims for better implementation logic O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.37.0
Development

Successfully merging a pull request may close this issue.

Replace check_header_and_update_state with an architecture similar to ibc-go cosmos/ibc-rs
2 participants
@plafer @Farhad-Shabani