Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding connectionID to portID generator fn #800

Closed
wants to merge 2 commits into from

Conversation

seantking
Copy link
Contributor

Description

Adding the connection sequence to the NewControllerPortID helper fn.

This change makes it possible for the API to be used in a way whereby a dev using InitInterchainAccount can use the same owner address for multiple host chains (represented by connection).

Alternatively, we could not make this change and ask the ica-auth module dev to create a unique owner-id per account and manage this whichever way they choose. In that case we simply need to update documentation and provide an example.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov-commenter
Copy link

Codecov Report

Merging #800 (e31bd89) into main (8dfbc9c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #800   +/-   ##
=======================================
  Coverage   79.50%   79.51%           
=======================================
  Files         146      146           
  Lines       10658    10660    +2     
=======================================
+ Hits         8474     8476    +2     
  Misses       1767     1767           
  Partials      417      417           
Impacted Files Coverage Δ
...7-interchain-accounts/controller/keeper/account.go 70.96% <100.00%> (ø)
modules/apps/27-interchain-accounts/types/port.go 100.00% <100.00%> (ø)

@seantking seantking closed this Jan 27, 2022
@seantking seantking deleted the sean/fix-controller-port-id branch August 3, 2022 13:59
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this pull request Nov 6, 2023
Depends on cosmos#799 

Unifies `VerifyAdjacent` and `VerifyNonAdjacent` into `Verify`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants