Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: restructure controller/host genesis types #799

Closed
wants to merge 3 commits into from

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Jan 27, 2022

Description

  • Moving ControllerGenesis and HostGenesis to their respective proto packages.
  • Adding connection_id to host genesis types

The purpose of this PR is to separate controller and host genesis types so that the new connection_id field is not added to the controller types redundantly.

Let's hold off on this until we further discuss the active channels and the issue below

ref: #767

This should be merged before: #791 and #790


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks for keeping this scoped, it was easy to review

@damiannolan
Copy link
Member Author

Closing in favour of consistent keys used in controller/host - splitting of genesis types is redundant

@damiannolan damiannolan deleted the damian/767-split-genesis branch March 29, 2022 09:00
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this pull request Nov 6, 2023
Necessary libp2p update before moving to go-header v0.2.0
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this pull request Nov 6, 2023
Depends on cosmos#799 

Unifies `VerifyAdjacent` and `VerifyNonAdjacent` into `Verify`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants