Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid invalid identifier error when validate genesis #7397

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Oct 7, 2024

that contains localhost client

Description

closes: #7396


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mmsqe for reporting the issue and providing a fix. I left a comment on an alternative solution, let me know what you think

modules/core/03-connection/types/keys.go Outdated Show resolved Hide resolved
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmsqe for the followup! Everything looks good to me

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mmsqe!

@damiannolan
Copy link
Member

Should we backport this?

@mmsqe
Copy link
Contributor Author

mmsqe commented Oct 7, 2024

Should we backport this?

Would be nice if we can backport to v8.5.x.

@colin-axner colin-axner added this pull request to the merge queue Oct 7, 2024
Merged via the queue into cosmos:main with commit ff2b668 Oct 7, 2024
82 checks passed
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
* fix: avoid invalid identifier error when validate genesis

that contains localhost client

* Apply suggestions from code review

* skip

(cherry picked from commit ff2b668)

# Conflicts:
#	CHANGELOG.md
#	modules/core/03-connection/types/genesis.go
#	modules/core/03-connection/types/genesis_test.go
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
* fix: avoid invalid identifier error when validate genesis

that contains localhost client

* Apply suggestions from code review

* skip

(cherry picked from commit ff2b668)

# Conflicts:
#	CHANGELOG.md
colin-axner added a commit that referenced this pull request Oct 8, 2024
…7397) (#7403)

* fix: avoid invalid identifier error when validate genesis (#7397)

* fix: avoid invalid identifier error when validate genesis

that contains localhost client

* Apply suggestions from code review

* skip

(cherry picked from commit ff2b668)

# Conflicts:
#	CHANGELOG.md
#	modules/core/03-connection/types/genesis.go
#	modules/core/03-connection/types/genesis_test.go

* chore: changelog cleanup

* chore: fix imports

---------

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Colin Axnér <[email protected]>
colin-axner added a commit that referenced this pull request Oct 8, 2024
…7397) (#7404)

* fix: avoid invalid identifier error when validate genesis (#7397)

* fix: avoid invalid identifier error when validate genesis

that contains localhost client

* Apply suggestions from code review

* skip

(cherry picked from commit ff2b668)

# Conflicts:
#	CHANGELOG.md

* chore: changelog cleanup

---------

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Colin Axnér <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Genesis validation fails after localhost client was added in InitGenesis
3 participants