fix: attempt to fix panics for unresolvable imports by using GogoResolver #7277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Publishing PR to run e2e test |
damiannolan
requested review from
colin-axner,
AdityaSripal and
chatton
as code owners
I think this is only unit tested atm? Either way, would be great to see if this addresses things. I definitely think its good to limit what files we go through as much as possible. |
colin-axner
approved these changes
Sep 10, 2024
DimitrisJim
approved these changes
Sep 10, 2024
damiannolan
requested review from
crodriguezvega,
gjermundgaraba and
bznein
as code owners
damiannolan
commented
Sep 10, 2024
|
Merged
10 tasks
Closed
10 tasks
DimitrisJim
pushed a commit
that referenced
this pull request
Sep 11, 2024
…lver (backport #7277) (#7281) * fix: attempt to fix panics for unresolvable imports by using GogoResolver (#7277) * fix: attempt to fix panics for unresolvable imports by using GogoResolver * chore: add changelog * chore: amend changelog (cherry picked from commit 79ddda5) # Conflicts: # CHANGELOG.md * chore: address merge conflicts in changelog --------- Co-authored-by: Damian Nolan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses the cosmos/gogoproto registry as opposed to including the entire merged global files registry.
closes: #7259
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.