Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: newModuleQuerySafeAllowList panics #7259

Closed
julienrbrt opened this issue Sep 6, 2024 · 3 comments · Fixed by #7277
Closed

Bug: newModuleQuerySafeAllowList panics #7259

julienrbrt opened this issue Sep 6, 2024 · 3 comments · Fixed by #7277
Assignees
Labels
27-interchain-accounts type: bug Something isn't working as expected

Comments

@julienrbrt
Copy link
Member

When using IBC >= 8.2.0 with rollkit, the keeper will panic because of some proto definition not found. It looks like ignite/cli#4318 hasn't entirely resolved the issue.

ref: ignite/cli#4318 (comment)
ref: #6436 (comment)

@crodriguezvega crodriguezvega added type: bug Something isn't working as expected 27-interchain-accounts labels Sep 9, 2024
@damiannolan
Copy link
Member

damiannolan commented Sep 9, 2024

I think this is popping up with rollkit apps using ignite because of the dependency on go-libp2p.
Rollkit app imports rollkit (rather than cometbft) and it depends on go-libp2p - which where the mentioned proto files in the stacktraces seem to be coming from:

I don't have deep understanding of how exactly gogoproto handles the whole proto registry file descriptors via MergedGlobalFileDescriptors etc, and how it populates that registry.
From my understanding, go package loader includes go-libp2p/core/crypto/pb/crypto.pb.go and thus file descriptor is available to be gathered by gogoproto MergedGlobalFileDescriptors

Trying to understand where there is a dependency on these files and/or if not, then why are are we seeing panics when AllowUnresolvable is true. I have not yet stepped through this entire trace with debugger to isolate the exact panic - looks like here https://github.com/protocolbuffers/protobuf-go/blob/v1.34.2/reflect/protodesc/desc_resolve.go#L47
https://github.com/protocolbuffers/protobuf-go/blob/v1.34.2/reflect/protodesc/desc_resolve.go#L201

@damiannolan
Copy link
Member

related CosmWasm/wasmd#1785

@damiannolan
Copy link
Member

We should test this with rollkit using #7278 which is a branch against v8.5.x rather than the PR targetting main, which would contain a lot more diffs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27-interchain-accounts type: bug Something isn't working as expected
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

3 participants