Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ics29 to tip of main #716

Merged
merged 108 commits into from
Jan 12, 2022
Merged

update ics29 to tip of main #716

merged 108 commits into from
Jan 12, 2022

Conversation

colin-axner
Copy link
Contributor

Description

This was messy to update. I didn't fully spend time fleshing out the tests for the OnChanOpenTry API change, so an issue should be opened to revisit that

closes: #713

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

dependabot bot and others added 30 commits August 23, 2021 12:00
@dependabot
Bump github.com/spf13/cast from 1.4.0 to 1.4.1 (#338)
f6eb414 
Bumps [github.com/spf13/cast](https://github.com/spf13/cast) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/spf13/cast/releases)
- [Commits](spf13/cast@v1.4.0...v1.4.1)

---
updated-dependencies:
- dependency-name: github.com/spf13/cast
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @colin-axner
Bump github.com/tendermint/tendermint from 0.34.11 to 0.34.12 (#341)
f4a017e 
Bumps [github.com/tendermint/tendermint](https://github.com/tendermint/tendermint) from 0.34.11 to 0.34.12.
- [Release notes](https://github.com/tendermint/tendermint/releases)
- [Changelog](https://github.com/tendermint/tendermint/blob/master/CHANGELOG.md)
- [Commits](tendermint/tendermint@v0.34.11...v0.34.12)

---
updated-dependencies:
- dependency-name: github.com/tendermint/tendermint
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: colin axnér <[email protected]>
@crodriguezvega
fix broken links in integration.md (#340)
7b5a19f 
* fix broken link in integration.md

* fix: broken link to simulator.md file in cosmos-sdk docs

Co-authored-by: Carlos Rodriguez <[email protected]>
@lukerhoads @colin-axner
Created helper functions for emitting packet events (#343)
e86cdbe 
* Created helper functions for emitting packet events

* Fixed comments and re-ordered helper functions

Co-authored-by: colin axnér <[email protected]>
@colin-axner
Merge pull request from GHSA-qrhq-96mh-q8jv
ae36ab5
@dependabot @colin-axner
Bump codecov/codecov-action from 2.0.2 to 2.0.3 (#346)
662f4dd 
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2.0.2 to 2.0.3.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-action@v2.0.2...v2.0.3)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: colin axnér <[email protected]>
@dependabot
Bump actions/setup-go from 2.1.3 to 2.1.4 (#349)
950b92d 
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2.1.3 to 2.1.4.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v2.1.3...v2.1.4)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@colin-axner
increase port identifier limit to 128 characters (#344)
358bfa5 
* increase port identifier limit to 128 characters

increase port limit and add tests for port validation

* add changelog

* fix tests
@colin-axner
update codeowners to include new team members and granular ownership (#…
9d5da17 
…354)

* update codeowners

* add proto files to ownership
@colin-axner
bump SDK dependency (#367)
a6bf50d 
* update SDK dependency and fix changes

Removes tests from sdk_test.go which are no longer needed to upstream changes in the SDK
Fixes client_test.go due to inclusion of the fee in tx events

* bump SDK version to v0.44.0
@damiannolan
adding client status cli query (#372)
74182d8 
* adding client status cli query

* adding query client status cli to changelog

* updating long CLI help usage
@damiannolan
adding markdown link checker to ci workflows (#377)
90ce97e
@damiannolan @colin-axner
packet acknowledgment filtering (#375)
760d15a 
* adding packet commitments to QueryPacketAcknowledgementsRequest for filtering

* adding testcase for filtered packet ack query

* adding changelog entry for packet ack filtering

* updating packet sequences type to repeated uint64

* updating to query specific packet acks outside bounds of paginated req

* updating changelog field naming, removing redundant pagination in query test

* continue in favour of returning an error on query PacketAcknowledgements

* updating to return empty array of acks if none of the provided commitments are found

Co-authored-by: colin axnér <[email protected]>

Co-authored-by: colin axnér <[email protected]>
@dependabot
Bump github.com/tendermint/tendermint from 0.34.12 to 0.34.13 (#386)
a647546 
Bumps [github.com/tendermint/tendermint](https://github.com/tendermint/tendermint) from 0.34.12 to 0.34.13.
- [Release notes](https://github.com/tendermint/tendermint/releases)
- [Changelog](https://github.com/tendermint/tendermint/blob/v0.34.13/CHANGELOG.md)
- [Commits](tendermint/tendermint@v0.34.12...v0.34.13)

---
updated-dependencies:
- dependency-name: github.com/tendermint/tendermint
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@colin-axner
Change ICS 20 packet data amount to be string (#350)
06c2d76 
* modify proto defintions

* fix non string usage in code and various tests

* fix mbt tests

* fix bug in data validation

* fix various build issues

fix unaddressed issues from changing amount from uint64 to string

* add changelog entry

* apply review suggestions

Add check that amount is strictly positive
Construct granular error messages to indicate invalid amount value or failure to parse amount

* verify and fix telemetry bug

Verify msg panics on amounts > int64 by adding tests
Add checks to telemetry emission of transfer amounts to handle when the amount cannot be casted to float32
@charleenfei @colin-axner
fix: ibc build docs (#361)
2fbe682 
* initial fix commit

* add release v1.0.1 to versions

* improvements for docs website

* add new version

* address review comments

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: colin axnér <[email protected]>
@damiannolan @colin-axner
feat: scalable version queries (#384)
85b4383 
* adding protos for port query interface

* adding NegotiateAppVersion method to IBCModule interface

* adding grpc port query implementation and module surrounds

* adding NegotiateAppVersion implementation to apps/transfer and mocks

* updating ErrInvalidVersion error code

* adding grpc query tests for 05-port

* updating grpc naming, adding godocs, removing redundant query cli

* updating grpc query tests

* adding changelog entry for #384 app version negotiation

* fixing error formatting in transfer version negotiation

Co-authored-by: colin axnér <[email protected]>

* removing client/cli query

* updating grpc query naming, adding new fields and associated surrounds

Co-authored-by: colin axnér <[email protected]>
@dependabot
Bump codecov/codecov-action from 2.0.3 to 2.1.0 (#399)
7a6507b 
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2.0.3 to 2.1.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-action@v2.0.3...v2.1.0)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@colin-axner
bump go package to v2 (#400)
83315a9 
* bump go package to v2

* fix proto file generation

* fix links

* future proof script
@colin-axner @damiannolan
Add migration docs template and updates migration doc for 1.0 to 2.0 (#…
29d4455 
…401)

* add migration template and update v2 migration docs

* Update docs/migrations/ibc-migration-v100.md

Co-authored-by: Damian Nolan <[email protected]>

* Update docs/migrations/migration-template.md

Co-authored-by: Damian Nolan <[email protected]>

Co-authored-by: Damian Nolan <[email protected]>
@crodriguezvega
add releases.md file (#408)
9e39349 
* add releases.md file

* address review comment

Co-authored-by: Carlos Rodriguez <[email protected]>
@crodriguezvega
fix broken links (#415)
f705142 
* fix for a large portion of the broken links and adding config file for the markdown link checker

* modify link checker yaml to use config file

* fix link checker yaml

* fix some more links and the path to the config file for the markdown link checker

* fix some more dead links

* tweak markdown link checker configuration and remove deprecated section from docs

* address review comments

* fix url for png

Co-authored-by: Carlos Rodriguez <[email protected]>
@crodriguezvega
chore: update changelog (#422)
2d3181b 
Co-authored-by: Carlos Rodriguez <[email protected]>
@AdityaSripal @colin-axner
Adds Generic Middleware helper functions (#383)
4f63be0 
* add generic middleware helper functions

* Update modules/core/04-channel/types/version.go

Co-authored-by: colin axnér <[email protected]>

* remove app capability, add merge fn, changelog

* add back newline

Co-authored-by: colin axnér <[email protected]>
@dependabot @colin-axner
Bump github.com/spf13/viper from 1.8.1 to 1.9.0 (#427)
37eac69 
Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.8.1 to 1.9.0.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](spf13/viper@v1.8.1...v1.9.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/viper
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: colin axnér <[email protected]>
@crodriguezvega
update releases decision tree (#429)
46a1224 
Co-authored-by: Carlos Rodriguez <[email protected]>
@seantking
refactor: making IsBound a public function (#425)
a19d1ec 
* refactor: making IsBound a public function

* chore: make 05-port keeper function IsBound public

* test: adding test for IsBound

* chore: updating changelog

* fix: changelog
@colin-axner @AdityaSripal
feat: Reusability of Mock module for middleware integration tests (#432)
6e56b04 
* proof of concept for mock middleware

* add mock base app implementation and add documentation

* add changelog

* update wording

* Update CHANGELOG.md

* rename BaseApp to IBCApp

* fix testing readme

* Update testing/README.md

Co-authored-by: Aditya <[email protected]>
@colin-axner
bump SDK v0.44.0 -> v0.44.1 (#455)
50d5542 
* bump SDK v0.44.0 -> v0.44.1

* add changelog entry
@crodriguezvega
docs: add steps to revive expired client with governance proposal (#438)
e518dac 
* docs: add steps to revive expired client with governance proposal

* address review comments

* address more review comments

* address more review comments

Co-authored-by: Carlos Rodriguez <[email protected]>
colin-axner and others added 23 commits December 22, 2021 16:12
@colin-axner
bump glob-parent version in json package (#663)
25d4544
@dependabot @colin-axner
build(deps): bump actions/setup-go from 2.1.4 to 2.1.5 (#656)
ce4c81e 
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2.1.4 to 2.1.5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v2.1.4...v2.1.5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: colin axnér <[email protected]>
@colin-axner @damiannolan @crodriguezvega
docs: begin removal of internal "spec" directories (#634)
b7fb4f1 
* begin removal of spec docs within core ibc

* remove broken link

* Apply suggestions from code review

Co-authored-by: Damian Nolan <[email protected]>

* remove broken link

* remove broken links

* Apply suggestions from code review

Co-authored-by: Carlos Rodriguez <[email protected]>

Co-authored-by: Damian Nolan <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
@colin-axner
Modify OnChanOpenTry application callback to perform app version ne…
411c440 
…gotitation (#646)

* remove NegotiateAppVersion and AppVersion gRPC (#643)

The NegotiateAppVersion callback has been removed from the IBC Application interface.
The gRPC AppVersion has been removed.
The app version negoitation will be handled by applications by returning the version in OnChanOpenTry.

* Modify `OnChanOpenTry` to return application version (#650)

* modify OnChanOpenTry to return negotiated version

modify IBCModule interface function OnChanOpenTry to return the negotiated app version. Tests have not been updated

* fix ibc_module_test.go tests

* fix tests

* Apply suggestions from code review

* add handshake test case

* add CHANGELOG and migration docs

* update documentation

* fix broken link
@colin-axner
fix broken link (#664)
297df13
@colin-axner @tac0turtle
chore: update make build-docs, add docs build checker (#667)
ffc29d9 
* update Makefile, add docs build checker

* Update .github/workflows/check-docs.yml

Co-authored-by: Marko <[email protected]>

Co-authored-by: Marko <[email protected]>
@colin-axner
register ICA query server, fix panics in params query cli (#666)
ce71056 
Register the controller and host query servers to a chain.
Returns an error upon cli params query failure instead of panicing.
@crodriguezvega
update of roadmap with latest release (#653)
f849588 
* update of roadmap with latest release and changed the way release versions are encoded

* fixed typo

Co-authored-by: Carlos Rodriguez <[email protected]>
@dependabot
build(deps): bump actions/checkout from 2.3.1 to 2.4.0 (#672)
4523ef5 
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.1 to 2.4.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2.3.1...v2.4.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@colin-axner
allow ics20 to connect to middleware (#675)
e40cdec 
* allow ics20 to connect to middleware

Creates ics4Wrapper which allows middleware applications to only implement SendPacket to connect ics20 as an application in its middleware stack

* add changelog and migration doc

* fix migration doc spelling
@damiannolan
fix: register InterchainAccount as x/auth GenesisAccount (#676)
1bfa055 
* adding GenesisAccount interface registration for InterchainAccount impl

* updating RegisterInterfaces ica godoc
@crodriguezvega
enable mergify for backports (#678)
4575650 
Co-authored-by: Carlos Rodriguez <[email protected]>
@dependabot
build(deps): bump technote-space/get-diff-action from 5 to 6.0.1 (#684)
c351015 
Bumps [technote-space/get-diff-action](https://github.com/technote-space/get-diff-action) from 5 to 6.0.1.
- [Release notes](https://github.com/technote-space/get-diff-action/releases)
- [Changelog](https://github.com/technote-space/get-diff-action/blob/main/.releasegarc)
- [Commits](technote-space/get-diff-action@v5...v6.0.1)

---
updated-dependencies:
- dependency-name: technote-space/get-diff-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@crodriguezvega
update roadmap (#681)
67cd1a2 
* remove past quarter and fixed SDK version number from 0.45 or 0.46

* add roadmap of past quarter

Co-authored-by: Carlos Rodriguez <[email protected]>
@colin-axner @crodriguezvega
ADR 002: importing multiple ibc-go versions (#683)
3ff0927 
* initial draft of adr 2

* fix wording and remove references section

* fix formatting and add to README

* Apply suggestions from code review

Co-authored-by: Carlos Rodriguez <[email protected]>

* apply review suggestions

Co-authored-by: Carlos Rodriguez <[email protected]>
@colin-axner
improve 04-channel logging (#692)
087bc5d 
## Description



closes: #674 

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [x] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [x] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [x] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [x] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [x] Re-reviewed `Files changed` in the Github PR explorer
- [x] Review `Codecov Report` in the comment section below once CI passes
@nir1218 @crodriguezvega @colin-axner
add cli to get denom hash from trace path and base denom (#679)
cb9bf5d 
* get denom hash from denom trace

* revert .gitignore

* final revert

* ignore history files

* Update modules/apps/transfer/client/cli/query.go

Co-authored-by: Carlos Rodriguez <[email protected]>

* Update modules/apps/transfer/keeper/grpc_query.go

Co-authored-by: Carlos Rodriguez <[email protected]>

* Update modules/apps/transfer/keeper/keeper.go

Co-authored-by: Carlos Rodriguez <[email protected]>

* Update modules/apps/transfer/keeper/grpc_query.go

Co-authored-by: colin axnér <[email protected]>

* code review feedback integration

* moved new feature  to unreleased section

* fix duplicate block in success test case

* fix CHANGELOG format

* fix invalid trace path argument error handling

* refactor positive test case code

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: colin axnér <[email protected]>
@crodriguezvega
chore: separate import statements by type (#702)
f5962c3 
Co-authored-by: Carlos Rodriguez <[email protected]>
@damiannolan
adding ICS 27 Interchain Accounts to README.md supported apps (#708)
57679db
@colin-axner
Merge branch 'main' of github.com:cosmos/ibc-go into ics29-fee-middle…
53b2f67 
…ware
@colin-axner
update imports to v3
e0cc81a
@colin-axner
regenerate proto files
120fd76
@colin-axner
fix build
0fbc6bb
@colin-axner colin-axner merged commit dbda885 into ics29-fee-middleware Jan 12, 2022
@colin-axner colin-axner deleted the colin/713-update-ics29-branch branch January 12, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleenfei charleenfei charleenfei approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@fedekunze fedekunze Awaiting requested review from fedekunze

@seantking seantking Awaiting requested review from seantking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.