New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: separate import statements by type #702

Merged

crodriguezvega merged 2 commits into main from carlos/382-separate-import-statements-by-type

Jan 10, 2022

Contributor

crodriguezvega commented Jan 9, 2022

Description

Would be good to see if this can be automated when a file is saved...

Should we add this convention to a coding guidelines document?

closes: #382

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes


          chore: separate import statements by type

1715d84

crodriguezvega requested review from AdityaSripal, charleenfei, colin-axner, damiannolan, fedekunze and seantking as code owners

January 9, 2022 18:28

colin-axner approved these changes

View reviewed changes

Contributor

colin-axner commented Jan 10, 2022

Should we add this convention to a coding guidelines document?

Yes!


          Merge branch 'main' into carlos/382-separate-import-statements-by-type

88fbcaf

damiannolan reviewed

View reviewed changes

modules/core/02-client/client/cli/tx.go

@@ @@ -17,6 +14,9 @@ import ( @@
               	govcli "github.com/cosmos/cosmos-sdk/x/gov/client/cli"
               	govtypes "github.com/cosmos/cosmos-sdk/x/gov/types"
               	upgradetypes "github.com/cosmos/cosmos-sdk/x/upgrade/types"
+              	"github.com/pkg/errors"

Member

damiannolan Jan 10, 2022

Random question: Any ideas why this is used over std lib errors? I think that repo is archived. cc @colin-axner

Contributor

colin-axner Jan 10, 2022

No idea. Want to open an issue?

Member

damiannolan Jan 10, 2022

Sure. I can do! :)

damiannolan approved these changes

View reviewed changes

seantking approved these changes

View reviewed changes

crodriguezvega merged commit f5962c3 into main

crodriguezvega deleted the carlos/382-separate-import-statements-by-type branch

January 10, 2022 20:53

CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this pull request


          build(deps): bump github.com/spf13/viper from 1.14.0 to 1.15.0 (cosmo…

34b8fcb

…s#702)

Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from
1.14.0 to 1.15.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/spf13/viper/releases">github.com/spf13/viper's
releases</a>.</em></p>
<blockquote>
<h2>v1.15.0</h2>
<!-- raw HTML omitted -->
<h2>What's Changed</h2>
<h3>Exciting New Features 🎉</h3>
<ul>
<li>feat: add multiple endpoints support for remote by <a
href="https://github.com/mozartz"><code>@mozartz</code></a> in <a
href="https://github-redirect.dependabot.com/spf13/viper/pull/1464">spf13/viper#1464</a></li>
</ul>
<h3>Enhancements 🚀</h3>
<ul>
<li>Add DocBlock to WatchConfig by <a
href="https://github.com/glebik000"><code>@glebik000</code></a> in <a
href="https://github-redirect.dependabot.com/spf13/viper/pull/1467">spf13/viper#1467</a></li>
</ul>
<h3>Breaking Changes 🛠</h3>
<ul>
<li>Drop YAML v2 and TOML v1 by <a
href="https://github.com/sagikazarmark"><code>@sagikazarmark</code></a>
in <a
href="https://github-redirect.dependabot.com/spf13/viper/pull/1493">spf13/viper#1493</a></li>
<li>Drop support for Go 1.16 by <a
href="https://github.com/sagikazarmark"><code>@sagikazarmark</code></a>
in <a
href="https://github-redirect.dependabot.com/spf13/viper/pull/1494">spf13/viper#1494</a></li>
</ul>
<h3>Dependency Updates ⬆️</h3>
<ul>
<li>build(deps): bump github.com/spf13/afero from 1.9.2 to 1.9.3 by <a
href="https://github.com/dependabot"><code>@dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/spf13/viper/pull/1465">spf13/viper#1465</a></li>
<li>build(deps): bump github.com/magiconair/properties from 1.8.6 to
1.8.7 by <a
href="https://github.com/dependabot"><code>@dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/spf13/viper/pull/1475">spf13/viper#1475</a></li>
<li>build(deps): bump github.com/pelletier/go-toml/v2 from 2.0.5 to
2.0.6 by <a
href="https://github.com/dependabot"><code>@dependabot</code></a> in <a
href="https://github-redirect.dependabot.com/spf13/viper/pull/1466">spf13/viper#1466</a></li>
<li>build(deps): bump mheap/github-action-required-labels from 2 to 3 by
<a href="https://github.com/dependabot"><code>@dependabot</code></a> in
<a
href="https://github-redirect.dependabot.com/spf13/viper/pull/1482">spf13/viper#1482</a></li>
<li>build(deps): bump github.com/subosito/gotenv from 1.4.1 to 1.4.2 by
<a href="https://github.com/dependabot"><code>@dependabot</code></a> in
<a
href="https://github-redirect.dependabot.com/spf13/viper/pull/1488">spf13/viper#1488</a></li>
<li>build(deps): bump github.com/sagikazarmark/crypt from 0.8.0 to 0.9.0
by <a href="https://github.com/dependabot"><code>@dependabot</code></a>
in <a
href="https://github-redirect.dependabot.com/spf13/viper/pull/1490">spf13/viper#1490</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/choar816"><code>@choar816</code></a>
made their first contribution in <a
href="https://github-redirect.dependabot.com/spf13/viper/pull/1481">spf13/viper#1481</a></li>
<li><a href="https://github.com/lol768"><code>@lol768</code></a> made
their first contribution in <a
href="https://github-redirect.dependabot.com/spf13/viper/pull/1485">spf13/viper#1485</a></li>
<li><a href="https://github.com/mozartz"><code>@mozartz</code></a> made
their first contribution in <a
href="https://github-redirect.dependabot.com/spf13/viper/pull/1464">spf13/viper#1464</a></li>
<li><a href="https://github.com/glebik000"><code>@glebik000</code></a>
made their first contribution in <a
href="https://github-redirect.dependabot.com/spf13/viper/pull/1467">spf13/viper#1467</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/spf13/viper/compare/v1.14.0...v1.15.0">https://github.com/spf13/viper/compare/v1.14.0...v1.15.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/spf13/viper/commit/518241257478c557633ab36e474dfcaeb9a3c623"><code>5182412</code></a>
Add DocBlock to WatchConfig (<a
href="https://github-redirect.dependabot.com/spf13/viper/issues/1467">#1467</a>)</li>
<li><a
href="https://github.com/spf13/viper/commit/0755477020c2dffa85bdf3ff0d2f4402e8c53971"><code>0755477</code></a>
feat: add multiple endpoints support for remote</li>
<li><a
href="https://github.com/spf13/viper/commit/a7ad8cfcc498bf931c250cbfef65e320c98f707d"><code>a7ad8cf</code></a>
build(deps): bump github.com/sagikazarmark/crypt from 0.8.0 to
0.9.0</li>
<li><a
href="https://github.com/spf13/viper/commit/63630c2fcdf434d40a9396b7678b1d8e020288bc"><code>63630c2</code></a>
build(deps): bump github.com/subosito/gotenv from 1.4.1 to 1.4.2</li>
<li><a
href="https://github.com/spf13/viper/commit/996ab102144b89fff3318a57e780d62717bcedf8"><code>996ab10</code></a>
ci: update golangci-lint</li>
<li><a
href="https://github.com/spf13/viper/commit/982460e8e1b44e809b2b7d666a65d13aede436ce"><code>982460e</code></a>
feat!: drop Go 1.16 support</li>
<li><a
href="https://github.com/spf13/viper/commit/2f5cb62e1fa7874e7044f825095c79155a7776c4"><code>2f5cb62</code></a>
ci: cleanup tags</li>
<li><a
href="https://github.com/spf13/viper/commit/77fc1c3084ea7064db16816828cca7af47c04410"><code>77fc1c3</code></a>
feat!: drop toml v1 support</li>
<li><a
href="https://github.com/spf13/viper/commit/e42b933dbe09a4dca670a89fa98a55dddec014c0"><code>e42b933</code></a>
feat!: drop yaml v2 support</li>
<li><a
href="https://github.com/spf13/viper/commit/9e46b7652ff9b483ba5fde5932a6729d6921b3fa"><code>9e46b76</code></a>
build(deps): bump mheap/github-action-required-labels from 2 to 3</li>
<li>Additional commits viewable in <a
href="https://github.com/spf13/viper/compare/v1.14.0...v1.15.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/spf13/viper&package-manager=go_modules&previous-version=1.14.0&new-version=1.15.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

damiannolan damiannolan approved these changes

colin-axner colin-axner approved these changes

seantking seantking approved these changes

AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

charleenfei Awaiting requested review from charleenfei

fedekunze Awaiting requested review from fedekunze

Labels

None yet