Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rename code hash to checksum in 08-wasm docs #5133

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

crodriguezvega
Copy link
Contributor

Description

closes: #5074

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@github-actions github-actions bot added the docs Improvements or additions to documentation label Nov 20, 2023
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added 08-wasm protobuf Proto file definitions and protobuf code generation labels Nov 20, 2023
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@github-actions github-actions bot removed 08-wasm protobuf Proto file definitions and protobuf code generation labels Nov 20, 2023
@crodriguezvega crodriguezvega merged commit 99fbe68 into main Nov 20, 2023
21 checks passed
@crodriguezvega crodriguezvega deleted the carlos/rename-codehash-docs branch November 20, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace occurences of codeHash, code_hash with checkSum
5 participants