Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace occurences of codeHash, code_hash with checkSum #5074

Closed
2 of 3 tasks
DimitrisJim opened this issue Nov 9, 2023 · 3 comments · Fixed by #5133
Closed
2 of 3 tasks

Replace occurences of codeHash, code_hash with checkSum #5074

DimitrisJim opened this issue Nov 9, 2023 · 3 comments · Fixed by #5133
Assignees
Labels
08-wasm type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Nov 9, 2023

Feedback from Simon's peer review:

Consistently rename code_hash -> checksum. Those are two terms for the same thing, which is confusing. cosmwasm-vm/wasmvm uses “checksum” everywhere.

We might want to use a different name for the hex encoded checksums returned by the QueryCodeHashesRequest and the one supplied to QueryCodeRequest. checkSumHex is an unimaginative first stab at it.

Can be done after feature branch is merged.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added type: code hygiene Clean up code but without changing functionality or interfaces 08-wasm labels Nov 9, 2023
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Nov 11, 2023
@crodriguezvega crodriguezvega added this to the 08-wasm/v0.1.0 milestone Nov 12, 2023
@DimitrisJim DimitrisJim self-assigned this Nov 13, 2023
@DimitrisJim
Copy link
Contributor Author

note: will probably require updates to documentation

@colin-axner
Copy link
Contributor

This can be closed?

@DimitrisJim
Copy link
Contributor Author

This can be closed?

keeping open for doc changes, wanted to push through main changes and keep the docs amendments in a follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08-wasm type: code hygiene Clean up code but without changing functionality or interfaces
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants