Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core, apps): 'PacketDataProvider' interface added and implemented (backport #4199) #4218

Merged
merged 4 commits into from
Aug 2, 2023

Commits on Aug 1, 2023

  1. feat(core, apps): 'PacketDataProvider' interface added and implemented (

    #4199)
    
    * refactor(core/exported): moved packet interfaces to packet.go
    
    * feat(core/exported): 'PacketDataProvider' interface added
    
    * feat(transfer): PacketDataProvider implemented
    
    * feat(ica): implemented PacketDataProvider
    
    * style(transfer_test, ica_test): improved test name
    
    * docs(core.adr8): updated godocs
    
    * style(ica_test): changed a variable name
    
    * docs(core.adr8): added missing '.'
    
    * imp(transfer): removed type assertion on jsonKey
    
    * fix(transfer_test): removed unused test case parameter
    
    * docs(transfer): updated godocs
    
    * imp(ica): removed type assertion from 'GetCustomPacketData'
    
    * imp(transfer_test): improved tests without type assertion
    
    * imp(ica_test): improved tests without type assertion
    
    * style(transfer_test): changed test case parameter name
    
    (cherry picked from commit a0a6526)
    
    # Conflicts:
    #	modules/apps/27-interchain-accounts/types/packet.go
    #	modules/apps/transfer/types/packet.go
    #	modules/core/exported/channel.go
    srdtrk authored and mergify[bot] committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    2d7e023 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. fix: fixed backport conflicts

    srdtrk committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    4bfb809 View commit details
    Browse the repository at this point in the history
  2. style: ran gofumpt

    srdtrk committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    1d888d3 View commit details
    Browse the repository at this point in the history
  3. style(ica_test): typo fixed

    srdtrk committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    6ac3471 View commit details
    Browse the repository at this point in the history