e2e: add missing params tests to CI #4207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal,
charleenfei,
damiannolan,
chatton and
DimitrisJim
as code owners
crodriguezvega
commented
Jul 31, 2023
| @@ -20,6 +20,7 @@ | |||
| ], | |||
| "test": [ | |||
| "TestClientUpdateProposal_Succeeds", | |||
| "TestClient_Update_Misbehaviour", | |||
There was a problem hiding this comment.
Noticed this was missing, so I added it for free in this PR.
There was a problem hiding this comment.
I feel like we should drop an underscore TestClientUpdate_Misbehaviour 😅 but its fine!
There was a problem hiding this comment.
I'd be happy with that change too :D, would need to make sure to update all the other json files though
damiannolan
approved these changes
Jul 31, 2023
| @@ -20,6 +20,7 @@ | |||
| ], | |||
| "test": [ | |||
| "TestClientUpdateProposal_Succeeds", | |||
| "TestClient_Update_Misbehaviour", | |||
There was a problem hiding this comment.
I feel like we should drop an underscore TestClientUpdate_Misbehaviour 😅 but its fine!
DimitrisJim
approved these changes
Jul 31, 2023
chatton
approved these changes
Aug 1, 2023
| @@ -20,6 +20,7 @@ | |||
| ], | |||
| "test": [ | |||
| "TestClientUpdateProposal_Succeeds", | |||
| "TestClient_Update_Misbehaviour", | |||
There was a problem hiding this comment.
I'd be happy with that change too :D, would need to make sure to update all the other json files though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #2010
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.