Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate params to be self managed #2010

Closed
8 of 12 tasks
colin-axner opened this issue Aug 15, 2022 · 3 comments · Fixed by #4207
Closed
8 of 12 tasks

Migrate params to be self managed #2010

colin-axner opened this issue Aug 15, 2022 · 3 comments · Fixed by #4207
Assignees
Labels
Milestone

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Aug 15, 2022

Summary

Migrate all our on-chain params to be self managed, the SDK is removing x/param

See example pr

See upgrading docs

Ensure unset module params don't cause a panic on genesis export

The module will be removed after April 18th, 2023

Issues:


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega
Copy link
Contributor

crodriguezvega commented Jan 22, 2023

Looking at the PR for migrating x/mint it looks like we need to:

In tx.proto:

In types/msgs.go:

In keeper/msg_server.go:

In types/keys.go:

  • Add key ParamsKey. This is the key that will be used to store the params.

In keeper/keeper.go:

Since NewKeeper takes an authority parameter (this is an API breaking change), we should adjust calls to pass in as authority authtypes.NewModuleAddress(govtypes.ModuleName).String().

And further:

In types/params.go:

In module.go:

I believe we need to do this for:

  • 02-client
  • 03-connection
  • transfer
  • 27 host
  • 27 controller

I guess we will need to adjust the existing tests setting params for 03-connection and transfer (this and this).

@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Jan 22, 2023
@crodriguezvega crodriguezvega modified the milestones: v7.0.0, v8.0.0 Jan 23, 2023
@crodriguezvega crodriguezvega moved this from Todo to Backlog in ibc-go Jan 24, 2023
@crodriguezvega
Copy link
Contributor

crodriguezvega commented Jan 25, 2023

When working on this we need to update the documentation at the bottom here regarding adding a light client to the list of allowed clients via a param change governance proposal.

@damiannolan
Copy link
Member

We should add an upgrade handler and e2e chain upgrade test for v7 -> v8 which performs the migrations and does some parameter lookups and assertions to make sure everything is set correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done 🥳
4 participants