Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GRPc Query for Upgrade #3491
Add GRPc Query for Upgrade #3491
Changes from all commits
995c1f1
f8f6ad4
808ec70
8dd0c44
64878ae
51bb7a7
f203df9
837e3c9
5f9ad67
7bdf33c
13812eb
2f7d0fc
28779f5
08af922
458b171
93db50e
b83849a
f29e2f8
09ddf84
8f36c16
0b36176
dfd9be3
f7eb3dd
c631e06
b8b5ca4
0e8092b
d18ca78
63c6acd
4f4bff2
fe9e8ef
f35cfbd
4f7109e
816f930
d5eb9b3
7ed8706
ddf721b
086e065
8684782
4c3b627
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is unrelated to this PR i guess, but this const is a bit random here if we are just using string values in all the rest of the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff would be quite large if I changed all of these here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add one more test for querying an upgrade on a channel that hasn't initiated an upgrade yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test is actually just directly setting the upgrade in state, the upgrade isn't being set in the ChanUpgradeInit function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually we can still do this by just deleting the key 👍