Add GRPc Query for Upgrade #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-upgrade-type-and-validate-basic-functions
…e-basic-functions' into cian/issue#3451-add-verifiable-upgrade-type-and-validate-basic-functions
…ype' of https://github.com/cosmos/ibc-go into cian/issue#3447-modify-upgradeinit-to-use-new-upgrade-type
…e instead of just version
…ype' into cian/issue#3481-grpc-query-for-type.upgrade
chatton
changed the base branch from
cian/issue#3447-modify-upgradeinit-to-use-new-upgrade-type
to
04-channel-upgrades
chatton
changed the base branch from
04-channel-upgrades
to
cian/issue#3447-modify-upgradeinit-to-use-new-upgrade-type
Base automatically changed from
cian/issue#3447-modify-upgradeinit-to-use-new-upgrade-type
to
04-channel-upgrades
April 19, 2023 14:30
chatton
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
colin-axner
approved these changes
Apr 20, 2023
charleenfei
reviewed
Apr 25, 2023
| @@ -11,6 +11,7 @@ import ( | |||
| "github.com/cosmos/ibc-go/v7/modules/core/04-channel/types" | |||
| "github.com/cosmos/ibc-go/v7/modules/core/exported" | |||
| ibctesting "github.com/cosmos/ibc-go/v7/testing" | |||
| "github.com/cosmos/ibc-go/v7/testing/mock" | |||
| ) | |||
|
|
|||
| const doesnotexist = "doesnotexist" | |||
There was a problem hiding this comment.
this is unrelated to this PR i guess, but this const is a bit random here if we are just using string values in all the rest of the tests
There was a problem hiding this comment.
diff would be quite large if I changed all of these here
charleenfei
reviewed
Apr 25, 2023
| } | ||
| }, | ||
| false, | ||
| }, |
There was a problem hiding this comment.
should we add one more test for querying an upgrade on a channel that hasn't initiated an upgrade yet?
There was a problem hiding this comment.
this test is actually just directly setting the upgrade in state, the upgrade isn't being set in the ChanUpgradeInit function
There was a problem hiding this comment.
actually we can still do this by just deleting the key 👍
charleenfei
approved these changes
Apr 25, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
for review after #3456 is mergedcloses: #3481
Commit Message / Changelog Entry
N/A feature branch
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.