Add simulations for 27-interchain-accounts app

[alpe]

Summary

Please support Cosmos-SDK simulation

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned

[colin-axner]

Hey @alpe, do you have a specific use case in mind? What sort of support are you looking for?

We haven't added simulation to IBC application before because we have previously deemed such changes too complex to implement for two simapps connecting to each other (simulating handshakes, client/connection/channel creation) and we deemed simulation support unnecessary. Simulations have historically been used to catch math bugs (staking, distribution etc), but the IBC applications thus far haven't not been very math heavy.

We do have the testing package, but perhaps this is not sufficient for your use case?

I'd love to see IBC testing expanded to include full integration tests and fuzz testing, but want to make sure we put our efforts towards the right solutions

[alpe]

Thanks for the feedback! I found simulations very helpful to detect integration issues in the past. Personally, I see them also as a mechanism to plug in test sets from different modules to the app, where they can add value without requiring people to have deeper knowledge of the module.
I do understand your point though, that ibc requires state which makes things more complicated.
If this makes sense for you, I can do a spike with one or two messages to get this started

Sorry, my original issue should be refined to: implement the AppModuleSimulation interface in the interchain account module. Otherwise the state export in sim tests fails when exporting params.

--- FAIL: TestAppImportExport (10.65s)
panic: UnmarshalJSON cannot decode empty bytes [recovered]
	panic: UnmarshalJSON cannot decode empty bytes

goroutine 10 [running]:
testing.tRunner.func1.2({0x5300d40, 0xc0057e5d00})
	/usr/local/Cellar/go/1.18.2/libexec/src/testing/testing.go:1389 +0x24e
testing.tRunner.func1()
	/usr/local/Cellar/go/1.18.2/libexec/src/testing/testing.go:1392 +0x39f
panic({0x5300d40, 0xc0057e5d00})
	/usr/local/Cellar/go/1.18.2/libexec/src/runtime/panic.go:838 +0x207
github.com/cosmos/cosmos-sdk/x/params/types.Subspace.Get({{0x5e0c958, 0xc0005a62b0}, 0xc0001222b8, {0x5def400, 0xc0005a7f80}, {0x5def450, 0xc000e74050}, {0xc000d16210, 0x7, 0x14}, ...}, ...)
	/Users/alex/go/pkg/mod/github.com/cosmos/[email protected]/x/params/types/subspace.go:109 +0x307
github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/host/keeper.Keeper.IsHostEnabled(...)
	/Users/alex/go/pkg/mod/github.com/cosmos/ibc-go/[email protected]/modules/apps/27-interchain-accounts/host/keeper/params.go:13
github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/host/keeper.Keeper.GetParams({{0x5def400, 0xc000e74020}, {0x5e0c958, 0xc0005a62b0}, {{0x5e0c958, 0xc0005a62b0}, 0xc0001222b8, {0x5def400, 0xc0005a7f80}, {0x5def450, ...}, ...}, ...}, ...)
	/Users/alex/go/pkg/mod/github.com/cosmos/ibc-go/[email protected]/modules/apps/27-interchain-accounts/host/keeper/params.go:26 +0x148
github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/host/keeper.ExportGenesis({{0x5e03358, 0xc000126008}, {0x5e0dbc0, 0xc0034ffdc0}, {{0x0, 0x0}, {0x0, 0x0}, 0x1, {0x388c9fa0, ...}, ...}, ...}, ...)
	/Users/alex/go/pkg/mod/github.com/cosmos/ibc-go/[email protected]/modules/apps/27-interchain-accounts/host/keeper/genesis.go:38 +0x1b8
github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts.AppModule.ExportGenesis({{}, _, _}, {{0x5e03358, 0xc000126008}, {0x5e0dbc0, 0xc0034ffdc0}, {{0x0, 0x0}, {0x0, ...}, ...}, ...}, ...)
	/Users/alex/go/pkg/mod/github.com/cosmos/ibc-go/[email protected]/modules/apps/27-interchain-accounts/module.go:181 +0x298

A GenerateGenesisState with defaults and otherwise boilerplate code would be enough. No operations needed to make it pass.

[gosuri]

Hey guys, any ETA on when this will be merged?

/cc @alessio

[crodriguezvega]

Sorry for the late reply... We're going to try to work on this in the coming 2 or 3 weeks. We will try to keep you all updated!