Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulations warning (AGAIN!) #201

Closed
noandrea opened this issue Aug 3, 2022 · 4 comments · Fixed by #202
Closed

Simulations warning (AGAIN!) #201

noandrea opened this issue Aug 3, 2022 · 4 comments · Fixed by #202
Labels
help wanted Extra attention is needed quality Issues related to testing or code quality

Comments

@noandrea
Copy link
Contributor

noandrea commented Aug 3, 2022

Looks like there is a problem with simulations and interchain accounts, here the stack trace of the simulation run:

exporting app state...
--- FAIL: TestAppSimulationAfterImport (23.48s)
panic: UnmarshalJSON cannot decode empty bytes [recovered]
	panic: UnmarshalJSON cannot decode empty bytes

goroutine 44 [running]:
testing.tRunner.func1.2({0x179a580, 0xc003413930})
	/snap/go/9848/src/testing/testing.go:1389 +0x24e
testing.tRunner.func1()
	/snap/go/9848/src/testing/testing.go:1392 +0x39f
panic({0x179a580, 0xc003413930})
	/snap/go/9848/src/runtime/panic.go:838 +0x207
github.com/cosmos/cosmos-sdk/x/params/types.Subspace.Get({{0x236e668, 0xc000eec310}, 0xc000010140, {0x2351918, 0xc000eedf10}, {0x2351968, 0xc000eedfd0}, {0xc000249d40, 0x7, 0x14}, ...}, ...)
	/home/andrea/.go/pkg/mod/github.com/cosmos/[email protected]/x/params/types/subspace.go:109 +0x307
github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/host/keeper.Keeper.IsHostEnabled(...)
	/home/andrea/.go/pkg/mod/github.com/cosmos/ibc-go/[email protected]/modules/apps/27-interchain-accounts/host/keeper/params.go:13
github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/host/keeper.Keeper.GetParams({{0x2351918, 0xc000eedfb0}, {0x236e668, 0xc000eec310}, {{0x236e668, 0xc000eec310}, 0xc000010140, {0x2351918, 0xc000eedf10}, {0x2351968, ...}, ...}, ...}, ...)
	/home/andrea/.go/pkg/mod/github.com/cosmos/ibc-go/[email protected]/modules/apps/27-interchain-accounts/host/keeper/params.go:26 +0x148
github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/host/keeper.ExportGenesis({{0x2364f38, 0xc000138000}, {0x236fba0, 0xc001c29500}, {{0x0, 0x0}, {0x0, 0x0}, 0x32, {0x0, ...}, ...}, ...}, ...)
	/home/andrea/.go/pkg/mod/github.com/cosmos/ibc-go/[email protected]/modules/apps/27-interchain-accounts/host/keeper/genesis.go:38 +0x1b8
github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts.AppModule.ExportGenesis({{}, _, _}, {{0x2364f38, 0xc000138000}, {0x236fba0, 0xc001c29500}, {{0x0, 0x0}, {0x0, ...}, ...}, ...}, ...)
	/home/andrea/.go/pkg/mod/github.com/cosmos/ibc-go/[email protected]/modules/apps/27-interchain-accounts/module.go:181 +0x298
github.com/cosmos/cosmos-sdk/types/module.(*Manager).ExportGenesis(_, {{0x2364f38, 0xc000138000}, {0x236fba0, 0xc001c29500}, {{0x0, 0x0}, {0x0, 0x0}, 0x32, ...}, ...}, ...)
	/home/andrea/.go/pkg/mod/github.com/cosmos/[email protected]/types/module/module.go:341 +0x125
github.com/elesto-dao/elesto/v2/app.(*App).ExportAppStateAndValidators(0xc00022f500, 0x0, {0x0, 0x0, 0x0})
	/home/andrea/Documents/workspaces/tendermint/elesto/elesto/app/export.go:34 +0x20b
github.com/cosmos/cosmos-sdk/simapp.CheckExportSimulation({0x7f64d02b5ba0, 0xc00022f500}, {{0x7fff644c9d32, 0x0}, {0x0, 0x0}, {0x7fff644c9d7a, 0x2a}, 0x0, {0x7fff644c9db6, ...}, ...}, ...)
	/home/andrea/.go/pkg/mod/github.com/cosmos/[email protected]/simapp/utils.go:82 +0xc7
github.com/elesto-dao/elesto/v2/app_test.TestAppSimulationAfterImport(0xc000683040)
	/home/andrea/Documents/workspaces/tendermint/elesto/elesto/app/simulation_test.go:262 +0x82f
testing.tRunner(0xc000683040, 0x2151ce0)
	/snap/go/9848/src/testing/testing.go:1439 +0x102
created by testing.(*T).Run
	/snap/go/9848/src/testing/testing.go:1486 +0x35f
FAIL	github.com/elesto-dao/elesto/v2/app	23.523s
FAIL


@noandrea noandrea added help wanted Extra attention is needed module:did quality Issues related to testing or code quality and removed module:did labels Aug 3, 2022
@gsora
Copy link
Contributor

gsora commented Aug 3, 2022

This bug has been introduced with 2eebd92.

@gsora
Copy link
Contributor

gsora commented Aug 3, 2022

I think I know what's going on.

app.sm is missing the Interchain Accounts simulation module, so its state is not getting generated, but it gets exported somehow.

Bad thing: the Interchain Accounts module at version 3.0.0 doesn't support simulations.

@gsora
Copy link
Contributor

gsora commented Aug 3, 2022

Someone had our exact issue in May: cosmos/ibc-go#1352

@gsora
Copy link
Contributor

gsora commented Aug 3, 2022

Turns out, even Akash has this issue: akash-network/node#1669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed quality Issues related to testing or code quality
Projects
None yet
2 participants