-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: deploy gh pages #541
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a1f4a76
deploy docs to gh pages
tac0turtle a1feb8d
change base
tac0turtle 3a02261
remove circle
tac0turtle 3cd3175
Update .github/workflows/docs.yml
tac0turtle b2ed27e
remove prefix
tac0turtle 70b7add
Merge branch 'github-pages' of https://github.com/cosmos/gaia into gi…
tac0turtle 58a2f5e
Merge branch 'main' into github-pages
tac0turtle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
name: Documentation | ||
# This job builds and deploys documenation to github pages. | ||
# It runs on every push to master. | ||
on: | ||
push: | ||
branches: | ||
- master | ||
|
||
jobs: | ||
build-and-deploy: | ||
runs-on: ubuntu-latest | ||
container: | ||
image: tendermintdev/docker-website-deployment | ||
steps: | ||
- name: Checkout 🛎️ | ||
uses: actions/[email protected] | ||
with: | ||
persist-credentials: false | ||
fetch-depth: 0 | ||
|
||
- name: Install and Build 🔧 | ||
run: | | ||
apk add rsync | ||
make build-docs LEDGER_ENABLED=false | ||
|
||
- name: Deploy 🚀 | ||
uses: JamesIves/[email protected] | ||
with: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
BRANCH: gh-pages | ||
FOLDER: ~/output |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,3 +49,27 @@ jobs: | |
file: ./coverage.txt # optional | ||
fail_ci_if_error: true | ||
if: "env.GIT_DIFF != ''" | ||
|
||
liveness-test: | ||
runs-on: ubuntu-latest | ||
timeout-minutes: 10 | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/[email protected] | ||
with: | ||
go-version: 1.15 | ||
- uses: technote-space/get-diff-action@v4 | ||
id: git_diff | ||
with: | ||
PATTERNS: | | ||
**/**.go | ||
go.mod | ||
go.sum | ||
- name: start localnet | ||
run: | | ||
make clean build-simd-linux localnet-start | ||
if: env.GIT_DIFF | ||
- name: test liveness | ||
run: | | ||
./contrib/localnet_liveness.sh 100 5 50 localhost | ||
if: env.GIT_DIFF |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I meant was to update the action with https://github.com/marketplace/actions/netlify-deploy And change the branch name to
netlify-docs
@marbar3778
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, but this migrates from github-pages to nelify. Cosmos-sdk and Tendermint are on github-pages, I'm not sure why gaia should be different?
I understand that something may be easier but having a unified system across all repos is better IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @marbar3778 in having a unified system, but also understand @lovincyrus about deploy previews. Fortunately, we can have both worlds, right? We point DNS at github pages and still link Netlify to the repo for deploy previews. Anyway, I think this PR should be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let's do that. For any new changes about Netlify, we can do that another time.