Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: deploy gh pages #541

Merged
merged 7 commits into from
Feb 5, 2021
Merged

docs: deploy gh pages #541

merged 7 commits into from
Feb 5, 2021

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Jan 13, 2021

Description

  • deploy docs to gh pages
  • remove circle

https://cosmos.github.io/gaia/main/hub-overview/overview.html

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #541 (a1f4a76) into main (d2222fc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #541   +/-   ##
=======================================
  Coverage   11.58%   11.58%           
=======================================
  Files           8        8           
  Lines         673      673           
=======================================
  Hits           78       78           
  Misses        586      586           
  Partials        9        9           

@tac0turtle tac0turtle marked this pull request as ready for review January 13, 2021 11:25
Makefile Outdated Show resolved Hide resolved
Copy link

@helder-moreira helder-moreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lovincyrus lovincyrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • deploy docs to github pages

Thanks for working on this @marbar3778

I noticed that we have already merged cosmos-sdk's docs github pages changes. Quick question: can we possibly use Netlify for deployment instead? It's easier for the redirects and deploy previews.

  1. Best practice for redirects? vuejs/vuepress#239 (comment)
  2. https://docs.netlify.com/routing/redirects/

Deploy previews is also crucial for docs that are using vuepress-theme-cosmos. In many cases, a md syntax / codeblock error might cause the docs build to break.

Now that the new master is main, which will break all the docs URLs, we should set up a redirect rule for /master/*

@lovincyrus
Copy link
Contributor

lovincyrus commented Jan 14, 2021

After some digging, I realized why @marbar3778 used gh-pages 💡:

  1. https://github.com/cosmos/cosmos-sdk/tree/gh-pages
  2. https://github.com/CosmWasm/docs/tree/gh-pages

We can have a better visibility of the versioned folders and ensure a persistent behavior during the version changes.

Let's make a couple of changes to the current setup.

1. gh-pages → netlify

2. _redirects

/master/* /main/:splat 301!

Ref: https://docs.netlify.com/routing/redirects/redirect-options/

With Netlify:

  1. easier to manipulate redirects
  2. deploy previews during dev
  3. 404 handling 404s Not Working vuepress-theme-cosmos#158, e.g. https://docs.cosmos.network/404

Netlify deployment of cosmos-sdk gh-pages branch: https://github.com/lovincyrus/cosmos-sdk-docs-netlify
Live: https://modest-euler-2bd497.netlify.app/

@lovincyrus
Copy link
Contributor

About Netlify, is there a Cosmos Netlify account? @okwme

@tac0turtle
Copy link
Member Author

1. gh-pages → netlify

* [github.com/marketplace/actions/netlify-deploy](https://github.com/marketplace/actions/netlify-deploy)

* select branch to deploy as `netlify-docs`

Are you suggesting this for staging or overall? We decided to go to github pages on all the repos. Keeping consistency is better than having it segregated.

2. _redirects

/master/* /main/:splat 301!

Ref: docs.netlify.com/routing/redirects/redirect-options

With Netlify:

1. easier to manipulate redirects

2. deploy previews during dev

3. 404 handling [cosmos/vuepress-theme-cosmos#158](https://github.com/cosmos/vuepress-theme-cosmos/issues/158), e.g. [docs.cosmos.network/404](https://docs.cosmos.network/404)

Netlify deployment of cosmos-sdk gh-pages branch: lovincyrus/cosmos-sdk-docs-netlify
Live: modest-euler-2bd497.netlify.app

It's already main: https://hub.cosmos.network/main/hub-overview/overview.html. Not sure when this happened, but couldn't we do the same thing we did for tendermint here? https://github.com/tendermint/tendermint/blob/master/docs/versions.

I am opposed to go to nelify for the main deployment but could make it used for staging deployments.

@lovincyrus
Copy link
Contributor

lovincyrus commented Jan 14, 2021

Are you suggesting this for staging or overall?

Staging and overall. It's mainly for these reasons tbh.

It's already main: https://hub.cosmos.network/main/hub-overview/overview.html.

Yes, we have switched to /main. But, we were using /master previously. Now that we have made the change, the old links with /master need to be redirected to /main.

Not sure when this happened, but couldn't we do the same thing we did for tendermint here? https://github.com/tendermint/tendermint/blob/master/docs/versions.

I'm not sure this is relevant to my suggestion to update deployment from gh-pages → netlify and configure redirects for the old links (/master).

make build-docs LEDGER_ENABLED=false

- name: Deploy 🚀
uses: JamesIves/[email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant was to update the action with https://github.com/marketplace/actions/netlify-deploy And change the branch name to netlify-docs

@marbar3778

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand, but this migrates from github-pages to nelify. Cosmos-sdk and Tendermint are on github-pages, I'm not sure why gaia should be different?

I understand that something may be easier but having a unified system across all repos is better IMO.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @marbar3778 in having a unified system, but also understand @lovincyrus about deploy previews. Fortunately, we can have both worlds, right? We point DNS at github pages and still link Netlify to the repo for deploy previews. Anyway, I think this PR should be merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's do that. For any new changes about Netlify, we can do that another time.

Copy link
Contributor

@shahankhatch shahankhatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marbar3778 I just realized that you were removing circle ci in this PR, but then I put in another PR for it. Do you want to remove the remove-circle-ci and liveness-test pieces, and keep only the doc building pieces for this PR?

@tac0turtle tac0turtle merged commit f50088d into main Feb 5, 2021
@tac0turtle tac0turtle deleted the github-pages branch February 5, 2021 09:41
alessio pushed a commit that referenced this pull request Feb 17, 2021
* Adding stub for migration guide (#586)

* Update Github actions pattern filter for go files, go.mod, and go.sum

* Updating changelog for v4

* Added PR link to changelog line item

* update discord link (#596)

* Fix Discord Links (#599)

* Update config.js

* Update overview.md

* Update README.md (#603)

Update Github license badge to branch `main` instead of former `master`

* Upgrade descriptions for cosmoshub-3 (#585)

* Upgrade descriptions for cosmoshub-3

* Remove any blockheight, since it is not known

* Add steps for the upgrade and more info around service providers

* Add info on backup

* Add info about x-crisis-skipp-assert-invariants

* Update to gaia v2.0.15

* Add grpc and state sync settings to the upgrade guide

* Replace unsafe-reset-all with init

* Use unsafe-reset-all, info about genesis hash value

* Fix repo name in license file (#604)

* Remove circleci (#597)

* ci: remove circleci

* Adding localnet sim to github action

* Remove file filter temporarily

* Re-enable file filter for action trigger

* Remove commented lines

* Linking file filter to actions

* Update .gaia directory and fixed timestamp for migrate (#607)

* Update .gaia directory and fixed timestamp for migrate

* Optimise readability in migrate step

* Add comment on new created genesis

* Adding resources to migration guide (#605)

* docs: deploy gh pages (#541)

* deploy docs to gh pages

* change base

* remove circle

* Update .github/workflows/docs.yml

* remove prefix

* push on main (#609)

* Cosmoshub 3 upgrade genesis initial height (#608)

* Change genesis timestamp to initial height

* Remove further explanation on time with initial height

* Removing dup liveness-test; was implemented in (#597) (#611)

* Bump github.com/tendermint/tm-db from 0.6.3 to 0.6.4 (#616)

* Bump github.com/tendermint/tm-db from 0.6.3 to 0.6.4

Bumps [github.com/tendermint/tm-db](https://github.com/tendermint/tm-db) from 0.6.3 to 0.6.4.
- [Release notes](https://github.com/tendermint/tm-db/releases)
- [Changelog](https://github.com/tendermint/tm-db/blob/master/CHANGELOG.md)
- [Commits](tendermint/tm-db@v0.6.3...v0.6.4)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* go.sum

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze <[email protected]>

* Bump github.com/spf13/cobra from 1.1.1 to 1.1.2 (#617)

* Bump github.com/spf13/cobra from 1.1.1 to 1.1.2

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.1.1 to 1.1.2.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md)
- [Commits](spf13/cobra@v1.1.1...v1.1.2)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* go.sum

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze <[email protected]>

* 100 validators to 125 validators (#618)

* 100 validators to 125 validators

* Update validator-faq.md

* Update validator-faq.md

* Update validator-faq.md

* Update validator-faq.md

* Update delegator-faq.md

* Update overview.md

* Update validator-setup.md

* Updates to release process (#588)

* Initial commit of updates

* Adding new RELEASING.md file

* Update contact info in COC

* Adding info on tag deletion, fixed reproducible build cmd

* Update .github/CODEOWNERS

Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: billy rennekamp <[email protected]>

* Add missing breaking changes file (#625)

* Add missing breaking changes file

* Update docs/migration/breaking_changes.md

Co-authored-by: Alessio Treglia <[email protected]>

* Bump github.com/tendermint/tendermint from 0.34.3 to 0.34.4 (#622)

* Bump github.com/tendermint/tendermint from 0.34.3 to 0.34.4

Bumps [github.com/tendermint/tendermint](https://github.com/tendermint/tendermint) from 0.34.3 to 0.34.4.
- [Release notes](https://github.com/tendermint/tendermint/releases)
- [Changelog](https://github.com/tendermint/tendermint/blob/v0.34.4/CHANGELOG.md)
- [Commits](tendermint/tendermint@v0.34.3...v0.34.4)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* go.sum

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze <[email protected]>

* Add memory hardware requirements to the upgrade guide (#621)

* Bump github.com/spf13/cobra from 1.1.2 to 1.1.3 (#619)

* Bump github.com/spf13/cobra from 1.1.2 to 1.1.3

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.1.2 to 1.1.3.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md)
- [Commits](spf13/cobra@v1.1.2...v1.1.3)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* go.sum

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Shahan Khatchadourian <[email protected]>

* remove version (#630)

* Add summary, pathways, full node operator guidance (#631)

* Applying fixes (#632)

* Create Cosmos Hub3 upgrade Instructions on ES_es (#613)

* Create Cosmos Hub3 upgrade Instructions on ES_es

* Update docs/migration/cosmoshub-3[ES_es].md

Co-authored-by: Federico Kunze <[email protected]>

* Update docs/migration/cosmoshub-3[ES_es].md

Co-authored-by: Federico Kunze <[email protected]>

* Update docs/migration/cosmoshub-3[ES_es].md

Co-authored-by: Federico Kunze <[email protected]>

* Update docs/migration/cosmoshub-3[ES_es].md

Co-authored-by: Federico Kunze <[email protected]>

* Update docs/migration/cosmoshub-3[ES_es].md

Co-authored-by: Federico Kunze <[email protected]>

* Update docs/migration/cosmoshub-3[ES_es].md

Co-authored-by: Federico Kunze <[email protected]>

* Update Cosmoshub-3 

Fedekunze's translation suggestions added.
Check (https://github.com/cosmos/gaia/pull/613#discussion_r573697546)[https://github.com/cosmos/gaia/pull/613#discussion_r573697546]

Co-authored-by: Federico Kunze <[email protected]>

* FIX: typo (#633)

* Depend on cosmos-sdk v0.41.1 (#635)

* FIX v4.0.0 hash (#634)

Co-authored-by: Jelena647 <[email protected]>
Co-authored-by: billy rennekamp <[email protected]>
Co-authored-by: Tobias Schwarz <[email protected]>
Co-authored-by: Marko <[email protected]>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: wimel <[email protected]>
Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: Nicolas Pinto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants