v8.0.x cleanups #2077
v8.0.x cleanups #2077
Conversation
faddat
requested review from
uditvira,
LexaMichaelides,
yaruwangway,
alexanderbez,
zmanian,
crodriguezvega,
jackzampolin,
mmulji-ic,
glnro,
jtremback and
mpoke
as code owners
|
Note that SDK 0.45.12 still uses go 1.18. Thus, we should not update to go 1.19. |
|
@mpoke If we use 1.18 then it is possible for validators to have mixed binaries. If we use 1.19 then it is impossible for validators to have mixed binaries. We studied this at osmosis. 1.19 good. 1.18 good. Mixed bad. Thus 1.19 |
|
@mpoke I've reverted to 1.18 -- please know that I do not recommend this, and urge that we use 1.19. Note: cosmos-sdk team recommends taking measures to ensure that we use only one version of go across the validator set: When we did this at Osmosis, we used Makefile + 1.18 -- however, after testing, and after a few validators having 1.19 related explosions because they install the chain in the logical manner, eg: go install ./...the go version was bumped to 1.19 because otherwise (present continuous verb) validators like myself will run into problems. There is no need to lower our go runtime version to match the SDK's, life is great with the higher one. The only thing we need to do is be at 1.18+. And... 1.18 puts validators into pickles. |
|
Kudos, SonarCloud Quality Gate passed!
|
| // TODO Remove it: https://github.com/cosmos/cosmos-sdk/issues/10409 | ||
| github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.8.1 | ||
|
|
||
| // use cosmos style protobufs | ||
| github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 | ||
|
|
||
| github.com/jhump/protoreflect => github.com/jhump/protoreflect v1.9.0 |
There was a problem hiding this comment.
Hi @faddat , where this is used ? and why we want v1.9.0 ? Thanks!
There was a problem hiding this comment.
I slavishly follow upstream recommendations, and that's recommended in the sdk.
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
|
Will return to this after we've got 47 in the main branch, but closing for now. |
This PR: