Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 validator set should use 1 major release of golang #13976

Closed
faddat opened this issue Nov 22, 2022 · 4 comments · Fixed by #14627
Closed

1 validator set should use 1 major release of golang #13976

faddat opened this issue Nov 22, 2022 · 4 comments · Fixed by #14627

Comments

@faddat
Copy link
Contributor

faddat commented Nov 22, 2022

Summary of Bug

When validator sets mix go 1.18 and 1.19, bad things seem to happen.

Since some distributions are shipping with go 1.19 and/or people's computers have go1.19, and if we require go 1.19, then validator sets should use it.

Version

any

Steps to Reproduce

have a validator set mix go 1.18 and 1.19 binaries, it seems to lead to apphash errors with the same code.

@tac0turtle
Copy link
Member

applications can enforce go versions across the chain. I agree there was an issue with go1.18 -> go1.19 but this is also generally seen as a breaking change for node operators and why we have shied away from it in the past

@faddat
Copy link
Contributor Author

faddat commented Nov 25, 2022

This is why I'm offering guidance; really want to make an sdk user guide.

Time is the main issue.

@julienrbrt
Copy link
Member

julienrbrt commented Jan 14, 2023

From the SDK perspective what were you thinking of?

I don't think we can do much more that adding an advice in the docs.

A small :::warning https://docs.cosmos.network/main/run-node/run-production here should do it right?

@faddat
Copy link
Contributor Author

faddat commented Jan 26, 2023

Thanks so much for finishing the job sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants