-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1 validator set should use 1 major release of golang #13976
Comments
applications can enforce go versions across the chain. I agree there was an issue with go1.18 -> go1.19 but this is also generally seen as a breaking change for node operators and why we have shied away from it in the past |
This is why I'm offering guidance; really want to make an sdk user guide. Time is the main issue. |
From the SDK perspective what were you thinking of? I don't think we can do much more that adding an advice in the docs. A small |
Thanks so much for finishing the job sir |
Summary of Bug
When validator sets mix go 1.18 and 1.19, bad things seem to happen.
Since some distributions are shipping with go 1.19 and/or people's computers have go1.19, and if we require go 1.19, then validator sets should use it.
Version
any
Steps to Reproduce
have a validator set mix go 1.18 and 1.19 binaries, it seems to lead to apphash errors with the same code.
The text was updated successfully, but these errors were encountered: