Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/internal: validate keys before calling ProofsFromMap (backport #9235) #9247

Merged
merged 2 commits into from
May 6, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 2, 2021

This is an automatic backport of pull request #9235 done by Mergify.
Cherry-pick of 711976e has failed:

On branch mergify/bp/release/v0.42.x/pr-9235
Your branch is up to date with 'origin/release/v0.42.x'.

You are currently cherry-picking commit 711976efc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   store/internal/proofs/create.go
	modified:   store/internal/proofs/create_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

Otherwise, an empty key as input or present in data can cause a panic at
runtime.

Caught by oss-fuzz: https://oss-fuzz.com/testcase-detail/4647668077953024

Fixes #9233

(cherry picked from commit 711976e)

# Conflicts:
#	CHANGELOG.md
@amaury1093 amaury1093 added this to the v0.42.5 milestone May 3, 2021
@alessio alessio merged commit 81b1049 into release/v0.42.x May 6, 2021
@alessio alessio deleted the mergify/bp/release/v0.42.x/pr-9235 branch May 6, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants