store/internal: validate keys before calling ProofsFromMap #9235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @odeke-em |
Codecov Report
@@ Coverage Diff @@
## master #9235 +/- ##
==========================================
+ Coverage 60.12% 60.14% +0.01%
==========================================
Files 595 595
Lines 37188 37194 +6
==========================================
+ Hits 22361 22369 +8
+ Misses 12847 12846 -1
+ Partials 1980 1979 -1
|
|
could you add a changelog please? |
alexanderbez
previously requested changes
Apr 30, 2021
Done
Done |
robert-zaremba
added
backport/0.42.x (Stargate)
A:automerge
|
@alexanderbez - could you release your block on this PR? Everything was addressed. |
Otherwise, an empty key as input or present in data can cause a panic at runtime. Caught by oss-fuzz: https://oss-fuzz.com/testcase-detail/4647668077953024 Fixes #9233
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2021
Otherwise, an empty key as input or present in data can cause a panic at runtime. Caught by oss-fuzz: https://oss-fuzz.com/testcase-detail/4647668077953024 Fixes #9233 (cherry picked from commit 711976e) # Conflicts: # CHANGELOG.md
alessio
pushed a commit
that referenced
this pull request
May 6, 2021
…9235) (#9247) Fixes #9233 (cherry picked from commit 711976e) Co-authored-by: Cuong Manh Le <[email protected]> Co-authored-by: Amaury M <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Otherwise, an empty key as input or present in data can cause a panic at
runtime.
Caught by oss-fuzz: https://oss-fuzz.com/testcase-detail/4647668077953024
Fixes #9233
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes