Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add orderBy parameter to TxsByEvents #8815

Merged
merged 18 commits into from
Mar 15, 2021
Merged

add orderBy parameter to TxsByEvents #8815

merged 18 commits into from
Mar 15, 2021

Conversation

aleem1314
Copy link
Contributor

Description

closes: #8686

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Mar 8, 2021 •
edited
Loading

Codecov Report

Merging #8815 (c301dda) into master (42919c8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8815   +/-   ##
=======================================
  Coverage   59.17%   59.17%           
=======================================
  Files         571      571           
  Lines       31800    31800           
=======================================
  Hits        18817    18817           
  Misses      10780    10780           
  Partials     2203     2203
Impacted Files Coverage Δ
x/auth/tx/service.go 72.85% <100.00%> (ø)

@alexanderbez alexanderbez mentioned this pull request Mar 9, 2021
Closed
4 tasks
@aleem1314 aleem1314 marked this pull request as ready for review March 10, 2021 05:50
@aleem1314 aleem1314 assigned anilcse and unassigned anilcse Mar 10, 2021
@aleem1314 aleem1314 requested a review from anilcse March 10, 2021 05:50
@alessio
Copy link
Contributor

alessio commented Mar 10, 2021

Good work - tests are still failing though

@orijbot
Copy link

orijbot commented Mar 12, 2021

Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=8dfd45bfcdb22b757e0a2790609a0610bc5d9908

@orijbot
Copy link

orijbot commented Mar 12, 2021

Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=80cd4acacf6b4925a590631f1790eb33

@orijbot
Copy link

orijbot commented Mar 12, 2021

Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=888034871a57a4484414c3d77ebcd1f71a25d57c

@orijbot
Copy link

orijbot commented Mar 12, 2021

Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=06bf0f1776134bf8a165b441bb0dc84c

amaury1093
amaury1093 suggested changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending on #8815 (comment)

@orijbot
Copy link

orijbot commented Mar 15, 2021

Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=46e1f6534e524c06849afc5948f4f06d

@orijbot
Copy link

orijbot commented Mar 15, 2021

Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=d384dd10c27b8517ddf8fe2e7c3bc752ffed311e

@orijbot
Copy link

orijbot commented Mar 15, 2021

Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=b7b714ce7efc4f08b58eea3dcc3984c5

@orijbot
Copy link

orijbot commented Mar 15, 2021

Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=dd424ed207b4e55bc23de2b1e988d02ce1b1777b

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 15, 2021
@jgimeno
Copy link
Contributor

jgimeno commented Mar 15, 2021

I only see one little change, is this expected?

amaury1093
amaury1093 suggested changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgimeno, hmm you're right it's not expected, that's weird. @aleem1314 Can you double-check?

@aleem1314
Copy link
Contributor Author

@jgimeno, hmm you're right it's not expected, that's weird. @aleem1314 Can you double-check?

@AmauryM Looks like master branch is updated, maybe because of this commit.

@orijbot
Copy link

orijbot commented Mar 15, 2021

Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=3dcd332acc084ff2a295efded463abaa

@orijbot
Copy link

orijbot commented Mar 15, 2021

Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=47e3db08badfda43ff18cfd06135f359683992cd

@amaury1093
Copy link
Contributor

@AmauryM Looks like master branch is updated, maybe because of this commit.

This is super weird lol, how come adf5f62 is in master but this PR not merged!?

@alessio
Copy link
Contributor

alessio commented Mar 15, 2021

This is really weird

@mergify mergify bot merged commit 553aac5 into master Mar 15, 2021
@mergify mergify bot deleted the aleem/8686-txevents-orderby branch March 15, 2021 17:56
@orijbot
Copy link

orijbot commented Mar 15, 2021

Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=9c06509465ea49448732fff857631da6

@orijbot
Copy link

orijbot commented Mar 15, 2021

Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=553aac50305b02e406cd51479b48a99ca34b4a4e

mergify bot pushed a commit that referenced this pull request Mar 15, 2021
@aleem1314
add orderBy parameter to TxsByEvents (#8815)
8857b99 
* add orderBy parameter to grpc query

* add orderby parameter

* change orderBy param to enum

* lint

* proto lint

* add changelog

* Update x/auth/tx/service.go

Co-authored-by: Amaury <[email protected]>

Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Jonathan Gimeno <[email protected]>
Co-authored-by: Amaury <[email protected]>
(cherry picked from commit 553aac5)

# Conflicts:
#	x/auth/tx/service.go
@mergify mergify bot mentioned this pull request Mar 15, 2021
Merged
aleem1314 added a commit that referenced this pull request Mar 16, 2021
@aleem1314 @jgimeno
add orderBy parameter to TxsByEvents (#8815)
e3fc867 
Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Jonathan Gimeno <[email protected]>
@amaury1093 amaury1093 mentioned this pull request Mar 17, 2021
Closed
4 tasks
alessio pushed a commit that referenced this pull request Mar 17, 2021
@mergify @amaury1093
@aleem1314 @jgimeno
add orderBy parameter to TxsByEvents (bp #8815) (#8883)
177672f 
Closes: #8686

(cherry picked from commit 553aac5)

Co-authored-by: Amaury <[email protected]>
Co-authored-by: MD Aleem <[email protected]>
Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Jonathan Gimeno <[email protected]>
Co-authored-by: aleem1314 <[email protected]>
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ted341 ted341 ted341 left review comments

@alessio alessio alessio approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@sahith-narahari sahith-narahari Awaiting requested review from sahith-narahari

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@anilcse anilcse Awaiting requested review from anilcse

@fdymylja fdymylja Awaiting requested review from fdymylja

@gsora gsora Awaiting requested review from gsora

@jgimeno jgimeno Awaiting requested review from jgimeno

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C: gRPC Issues and PRs related to the gRPC service and HTTP gateway.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ServiceServer.TxsByEvents must accept an orderBy parameter
8 participants
@aleem1314 @alessio @orijbot @amaury1093 @jgimeno @aaronc @ted341 @anilcse