Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceServer.TxsByEvents must accept an orderBy parameter #8686

Closed
4 tasks
alessio opened this issue Feb 24, 2021 · 0 comments · Fixed by #8815
Closed
4 tasks

ServiceServer.TxsByEvents must accept an orderBy parameter #8686

alessio opened this issue Feb 24, 2021 · 0 comments · Fixed by #8815
Assignees
@aleem1314
Labels
T: Client UX

Comments

@alessio
Copy link
Contributor

alessio commented Feb 24, 2021

Forked from: tendermint/tendermint#6155

In TxSearch() calls in server/rosetta/client_online.go and x/auth/tx/service.go:

	txList, err := c.clientCtx.Client.TxSearch(ctx, txQuery, true, nil, nil, "")

"" is always passed as a value for the orderBy parameter. That should be replaced by user values.

Thanks for considering.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@aleem1314 aleem1314 mentioned this issue Mar 8, 2021
Merged
9 tasks
@alessio alessio mentioned this issue Mar 9, 2021
Closed
4 tasks
@mergify mergify bot closed this as completed in #8815 Mar 15, 2021
alessio pushed a commit that referenced this issue Mar 17, 2021
@mergify @amaury1093
@aleem1314 @jgimeno
add orderBy parameter to TxsByEvents (bp #8815) (#8883)
177672f 
Closes: #8686

(cherry picked from commit 553aac5)

Co-authored-by: Amaury <[email protected]>
Co-authored-by: MD Aleem <[email protected]>
Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Jonathan Gimeno <[email protected]>
Co-authored-by: aleem1314 <[email protected]>
@puneet2019 puneet2019 mentioned this issue Mar 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleem1314 aleem1314

Labels
T: Client UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add orderBy parameter to TxsByEvents cosmos/cosmos-sdk
2 participants
@alessio @aleem1314