Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DONTMERGE: v0.42.0 release train PR #8805

Closed
wants to merge 9 commits into from

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 5, 2021

PLEASE DON'T MERGE THIS PR

The only purpose of this PR is display the CI status of the v0.42.0 release train.
This pull request shall be closed, and the respective shall be deleted once v0.42.0 is out.

Thanks.

Ref #8668


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

clevinson and others added 6 commits March 4, 2021 08:13
Co-authored-by: Tomas Tauber <[email protected]>
Co-authored-by: yihuang <[email protected]>
Co-authored-by: Tomas Tauber <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit a9b034b)

Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 82aedba)

Co-authored-by: Marko <[email protected]>
Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit e17953a)

Co-authored-by: Marko <[email protected]>
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #8805 (f999b1f) into alessio/release-train-0.42.0 (3aaf1bc) will increase coverage by 0.11%.
The diff coverage is 85.71%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           alessio/release-train-0.42.0    #8805      +/-   ##
================================================================
+ Coverage                         61.95%   62.06%   +0.11%     
================================================================
  Files                               612      612              
  Lines                             35417    35431      +14     
================================================================
+ Hits                              21942    21992      +50     
+ Misses                            11155    11113      -42     
- Partials                           2320     2326       +6     
Impacted Files Coverage Δ
x/gov/client/utils/utils.go 33.33% <75.00%> (+33.33%) ⬆️
x/ibc/core/02-client/types/encoding.go 60.00% <77.77%> (+6.15%) ⬆️
store/cachekv/memiterator.go 65.78% <100.00%> (ø)
x/crisis/keeper/keeper.go 86.20% <100.00%> (ø)
x/evidence/types/evidence.go 87.50% <100.00%> (+19.75%) ⬆️
x/ibc/core/02-client/keeper/client.go 98.27% <100.00%> (+0.06%) ⬆️
x/gov/client/cli/query.go 70.30% <0.00%> (+1.16%) ⬆️
x/gov/client/rest/query.go 26.13% <0.00%> (+6.81%) ⬆️

Co-authored-by: Barrie Byron <[email protected]>
Co-authored-by: Cory <[email protected]>
@aaronc
Copy link
Member

aaronc commented Mar 8, 2021

Maybe mark as draft if you don't want it merged and/or put DNM in the title @alessio ?

@alessio alessio changed the title v0.42.0 release train PR DONTMERGE: v0.42.0 release train PR Mar 8, 2021
Copy link
Contributor

@jgimeno jgimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait

mergify bot and others added 2 commits March 8, 2021 16:16
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alessio alessio closed this Mar 8, 2021
@alessio
Copy link
Contributor Author

alessio commented Mar 8, 2021

Releasing, hence closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants