-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/gov: fix NormalizeProposalType() return values (bp #8808) #8816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
aaronc,
alessio and
alexanderbez
as code owners
March 8, 2021 14:39
alessio
approved these changes
Mar 8, 2021
alessio
requested review from
robert-zaremba,
amaury1093,
fdymylja,
gsora,
jgimeno and
sahith-narahari
March 8, 2021 14:43
gsora
approved these changes
Mar 8, 2021
amaury1093
approved these changes
Mar 8, 2021
Codecov Report
@@ Coverage Diff @@
## release/v0.42.x #8816 +/- ##
===================================================
+ Coverage 61.97% 62.06% +0.09%
===================================================
Files 612 612
Lines 35431 35431
===================================================
+ Hits 21960 21992 +32
+ Misses 11149 11113 -36
- Partials 2322 2326 +4
|
sahith-narahari
approved these changes
Mar 8, 2021
robert-zaremba
approved these changes
Mar 8, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #8808 done by Mergify.
Cherry-pick of be23295 has failed:
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/
Closes: #8806