Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize ADR-028 #8398

Merged
merged 32 commits into from
Feb 4, 2021
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
7b8173b
Finalize ADR-028
robert-zaremba Jan 20, 2021
8643cae
Merge branch 'master' into robert/adr-28
robert-zaremba Jan 20, 2021
6038410
added note about Named Accounts
robert-zaremba Jan 20, 2021
aecb45b
Update docs/architecture/adr-028-public-key-addresses.md
Jan 20, 2021
9a4e078
add reference to \#8041
robert-zaremba Jan 20, 2021
bbfb1b7
typo fix
robert-zaremba Jan 20, 2021
8129844
Apply suggestions from code review
robert-zaremba Jan 21, 2021
2724c7b
simplification, review updates
robert-zaremba Jan 22, 2021
8c44486
date update
robert-zaremba Jan 22, 2021
1557ef5
update paragraph about proto.MessageName
robert-zaremba Jan 22, 2021
aaf471b
remove the module name section - it's described in other section
robert-zaremba Jan 22, 2021
c230c68
Update docs/architecture/adr-028-public-key-addresses.md
robert-zaremba Jan 22, 2021
9b21ec5
remove blake2b
robert-zaremba Jan 27, 2021
9550d11
move some paragraphs to 'Further Discussion'
robert-zaremba Jan 27, 2021
c0a9b20
renames
robert-zaremba Jan 27, 2021
84f57b8
revert and merge 'Multisig Addresses' section
robert-zaremba Jan 27, 2021
c8fa6cb
Apply suggestions from code review
robert-zaremba Jan 29, 2021
3d29aff
Merge branch 'master' into robert/adr-28
robert-zaremba Jan 29, 2021
e407672
add LengthPrefix to Compose definition
robert-zaremba Jan 29, 2021
889b9c5
Merge branch 'master' into robert/adr-28
Jan 29, 2021
ab4b9d1
move composing module accounts to a new subsectoin
robert-zaremba Jan 30, 2021
834d997
adding appendix from meeting with Alan
robert-zaremba Jan 31, 2021
3ceb0f2
composed addresses: use LengthPrefix before sorting
robert-zaremba Feb 1, 2021
274efce
Update docs/architecture/adr-028-public-key-addresses.md
robert-zaremba Feb 1, 2021
461c703
Update docs/architecture/adr-028-public-key-addresses.md
robert-zaremba Feb 1, 2021
201a19e
adding special case for Module Account Addresses
robert-zaremba Feb 1, 2021
5093022
limit 'account' word usage
robert-zaremba Feb 1, 2021
6fb8701
describe submodule derivation
robert-zaremba Feb 2, 2021
eb23aa6
Add discussion notes for the module addresses + bring back 'account' …
robert-zaremba Feb 3, 2021
963b093
Apply suggestions from code review
robert-zaremba Feb 3, 2021
c79c796
changing back to proposed
robert-zaremba Feb 3, 2021
eae740c
Merge branch 'master' into robert/adr-28
robert-zaremba Feb 3, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading